commit 58d552ad1161670c4b419a07814a3c06763d4327
author Éamonn McManus <emcmanus@google.com> Wed May 17 13:20:24 2023 -0700
committer Javac Team <javac-team+copybara@google.com> Wed May 17 13:21:05 2023 -0700
tree ce4d1b8d37120d784d6a3ee596a9c61ff6d1d3ca
parent 0f203454983d11f842f1b3193799a0f4553228a2

Ensure that source jars are closed after being read.

PiperOrigin-RevId: 532885339

java/com/google/turbine/main/Main.java

diff --git a/java/com/google/turbine/main/Main.java b/java/com/google/turbine/main/Main.java
index 34984a8..45b0538 100644
--- a/java/com/google/turbine/main/Main.java
+++ b/java/com/google/turbine/main/Main.java
@@ -320,11 +320,13 @@
       units.add(Parser.parse(new SourceFile(source, MoreFiles.asCharSource(path, UTF_8).read())));
     }
     for (String sourceJar : options.sourceJars()) {
-      for (Zip.Entry ze : new Zip.ZipIterable(Paths.get(sourceJar))) {
-        if (ze.name().endsWith(".java")) {
-          String name = ze.name();
-          String source = new String(ze.data(), UTF_8);
-          units.add(Parser.parse(new SourceFile(name, source)));
+      try (Zip.ZipIterable iterable = new Zip.ZipIterable(Paths.get(sourceJar))) {
+        for (Zip.Entry ze : iterable) {
+          if (ze.name().endsWith(".java")) {
+            String name = ze.name();
+            String source = new String(ze.data(), UTF_8);
+            units.add(Parser.parse(new SourceFile(name, source)));
+          }
         }
       }
     }