kernel-shark: Don't use Data collection when checking if the bin is empty
When plotting a task graph and no data from the Task is found in the bin,
we check the CPU, previously used by the task, searching for data from
another task running on the same CPU. However this search will always
fail if we use the Data collection of the plotted task.
Link: http://lore.kernel.org/linux-trace-devel/20190213161216.14438-5-ykaradzhov@vmware.com
Fixes: ba206aaa45 ("kernel-shark-qt: Add C++ API for drawing of Graphs")
Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
diff --git a/kernel-shark/src/KsPlotTools.cpp b/kernel-shark/src/KsPlotTools.cpp
index f97c6e4..d07f414 100644
--- a/kernel-shark/src/KsPlotTools.cpp
+++ b/kernel-shark/src/KsPlotTools.cpp
@@ -929,13 +929,15 @@
} else {
/*
* No data from the Task in this bin. Check the CPU,
- * previously used by the task.
+ * previously used by the task. We are looking for
+ * data from another task running on the same CPU,
+ * hence we cannot use the collection of this task.
*/
int cpuPid = ksmodel_get_pid_back(_histoPtr,
bin,
lastCpu,
false,
- _collectionPtr,
+ nullptr, // No collection
nullptr);
if (cpuPid != KS_EMPTY_BIN) {
