commit 382f40ee4512573ff952a0596bcf3f45a50dc285
author Philip Tricca <philip.b.tricca@intel.com> Mon Feb 19 07:43:00 2018 -0800
committer Philip Tricca <philip.b.tricca@intel.com> Thu Feb 22 13:28:38 2018 -0800
tree 95a6d61c0ee59f16e644fb0eb9f4c3c5605cfc31
parent 21fa321f3024ecf872ae2487771c48a499c3dd8b

libtcti_device: Simplify debug output in transmit function.

Parsing out the header to get the size field when we've already got the
buffer size passed in as a parameter is a bit excessive. This allows us
to print the command code in a more human friendly form but this info is
readily available in the buffer we print.

Signed-off-by: Philip Tricca <philip.b.tricca@intel.com>

tcti/tcti_device.c

diff --git a/tcti/tcti_device.c b/tcti/tcti_device.c
index 0791217..e680241 100644
--- a/tcti/tcti_device.c
+++ b/tcti/tcti_device.c
@@ -55,26 +55,10 @@
     if (rval != TSS2_RC_SUCCESS) {
         return rval;
     }
-
-#if LOGLEVEL == LOGLEVEL_DEBUG || \
-    LOGLEVEL == LOGLEVEL_TRACE
-    TPM2_ST commandCode = 0xffff;
-    UINT32 cnt = 0xffffffff;
-    TSS2_RC rc;
-    size_t offset = sizeof (TPM2_ST);
-    rc = Tss2_MU_TPM2_ST_Unmarshal (command_buffer,
-                                   command_size,
-                                   &offset,
-                                   &commandCode);
-    if (rc) return rc;
-    rc = Tss2_MU_UINT32_Unmarshal (command_buffer,
-                                   command_size,
-                                   &offset,
-                                   &cnt);
-    if (rc) return rc;
-    LOGBLOB_DEBUG(command_buffer, cnt, "Cmd sent: %" PRIx16 "; Buffer:",
-        commandCode);
-#endif
+    LOGBLOB_DEBUG (command_buffer,
+                   command_size,
+                   "sending " PRIx16 " byte command buffer:",
+                   command_size);
     size = write (tcti_intel->devFile, command_buffer, command_size);
     if (size < 0) {
         LOG_ERROR("send failed with error: %d", errno);