commit b1ac2e15f4a6698986746bf815bce67d0bb0a4dd
author Cedric Beust <cedric@beust.com> Fri Sep 25 09:58:21 2015 -0700
committer Cedric Beust <cedric@beust.com> Fri Sep 25 09:58:21 2015 -0700
tree 595298895cbabf55061e60cc2ad7b7b09ef3c58e
parent 81086641710e79c0a0d933ad036d230a9c8a16ea
parent e46051c917baa1c6606e29a64f6a27f7fd026b77

Merge pull request #812 from juherr/issue-784

Fix issue #784: Duplicate error messages

src/main/java/org/testng/asserts/SoftAssert.java

diff --git a/src/main/java/org/testng/asserts/SoftAssert.java b/src/main/java/org/testng/asserts/SoftAssert.java
index 95dad5f..845bdea 100644
--- a/src/main/java/org/testng/asserts/SoftAssert.java
+++ b/src/main/java/org/testng/asserts/SoftAssert.java
@@ -11,7 +11,7 @@
  */
 public class SoftAssert extends Assertion {
   // LinkedHashMap to preserve the order
-  private Map<AssertionError, IAssert<?>> m_errors = Maps.newLinkedHashMap();
+  private final Map<AssertionError, IAssert<?>> m_errors = Maps.newLinkedHashMap();
 
   @Override
   protected void doAssert(IAssert<?> a) {
@@ -28,21 +28,16 @@
   }
 
   public void assertAll() {
-    if (! m_errors.isEmpty()) {
+    if (!m_errors.isEmpty()) {
       StringBuilder sb = new StringBuilder("The following asserts failed:");
       boolean first = true;
       for (Map.Entry<AssertionError, IAssert<?>> ae : m_errors.entrySet()) {
         if (first) {
           first = false;
         } else {
-          sb.append(", ");
+          sb.append(",");
         }
         sb.append("\n\t");
-        final String message = ae.getValue().getMessage();
-        if (message != null) {
-          sb.append(message).append("\t");
-        }
-        //noinspection ThrowableResultOfMethodCallIgnored
         sb.append(ae.getKey().getMessage());
       }
       throw new AssertionError(sb.toString());

src/test/java/test/assertion/SoftAssertTest.java

diff --git a/src/test/java/test/assertion/SoftAssertTest.java b/src/test/java/test/assertion/SoftAssertTest.java
index 66e850c..2aebaed 100644
--- a/src/test/java/test/assertion/SoftAssertTest.java
+++ b/src/test/java/test/assertion/SoftAssertTest.java
@@ -33,15 +33,18 @@
 
   @Test
   public void testAssertAllCount() throws Exception {
-    final SoftAssert sa = new SoftAssert();
+    String message = "My message";
+    SoftAssert sa = new SoftAssert();
     sa.assertTrue(true);
-    sa.assertTrue(false);
+    sa.assertTrue(false, message);
     try {
       sa.assertAll();
       Assert.fail("Exception expected");
     } catch (AssertionError e) {
-      final String message = e.getMessage();
-      Assert.assertEquals(message.split("\r?\n").length, 2, message);
+      String[] lines = e.getMessage().split("\r?\n");
+      Assert.assertEquals(lines.length, 2);
+      lines[1] = lines[1].replaceFirst(message, "");
+      Assert.assertFalse(lines[1].contains(message));
     }
   }
 }