small memory improvement, changing new Boolean() to Boolean.valueOf() &
improve loop
diff --git a/src/main/org/testng/internal/Constants.java b/src/main/org/testng/internal/Constants.java
index b4e83c4..eef0f73 100644
--- a/src/main/org/testng/internal/Constants.java
+++ b/src/main/org/testng/internal/Constants.java
@@ -66,7 +66,7 @@
String r = properties.getProperty(propertyName, p.getDefault());
boolean result = "true".equalsIgnoreCase(r);
- return new Boolean(result).booleanValue();
+ return Boolean.valueOf( result).booleanValue();
}
public static int getIntegerPropertyValue(Properties properties, String propertyName) {
diff --git a/src/main/org/testng/internal/Parameters.java b/src/main/org/testng/internal/Parameters.java
index 579331a..5d1f5b9 100644
--- a/src/main/org/testng/internal/Parameters.java
+++ b/src/main/org/testng/internal/Parameters.java
@@ -157,7 +157,7 @@
result = new Integer(Integer.parseInt(value));
}
else if(type == boolean.class || type == Boolean.class) {
- result = new Boolean(value);
+ result = Boolean.valueOf(value);
}
else if(type == byte.class || type == Byte.class) {
result = new Byte(Byte.parseByte(value));
diff --git a/src/main/org/testng/internal/annotations/Converter.java b/src/main/org/testng/internal/annotations/Converter.java
index 2b52808..3b63b50 100644
--- a/src/main/org/testng/internal/annotations/Converter.java
+++ b/src/main/org/testng/internal/annotations/Converter.java
@@ -17,7 +17,7 @@
public static boolean getBoolean(String tagValue, boolean def) {
boolean result = def;
- if (tagValue != null) result = new Boolean(tagValue).booleanValue();
+ if (tagValue != null) result = Boolean.valueOf(tagValue).booleanValue();
return result;
}
diff --git a/src/main/org/testng/reporters/SuiteHTMLReporter.java b/src/main/org/testng/reporters/SuiteHTMLReporter.java
index bf1de7f..4fc305a 100644
--- a/src/main/org/testng/reporters/SuiteHTMLReporter.java
+++ b/src/main/org/testng/reporters/SuiteHTMLReporter.java
@@ -271,7 +271,7 @@
}
private String dumpMethods(ITestNGMethod[] testMethods) {
- StringBuffer sb = new StringBuffer("");
+ StringBuffer sb = new StringBuffer();
if(null == testMethods || testMethods.length == 0) {
return "";
}
diff --git a/src/main/org/testng/xml/TestNGContentHandler.java b/src/main/org/testng/xml/TestNGContentHandler.java
index 80855f2..9349718 100644
--- a/src/main/org/testng/xml/TestNGContentHandler.java
+++ b/src/main/org/testng/xml/TestNGContentHandler.java
@@ -220,7 +220,7 @@
}
String jUnit = attributes.getValue("junit");
if (null != jUnit) {
- m_currentTest.setJUnit(new Boolean(jUnit).booleanValue());
+ m_currentTest.setJUnit( Boolean.valueOf(jUnit).booleanValue());
}
String parallel = attributes.getValue("parallel");
if (null != parallel) {
diff --git a/src/main/org/testng/xml/XmlSuite.java b/src/main/org/testng/xml/XmlSuite.java
index 5a83833..88ed23e 100644
--- a/src/main/org/testng/xml/XmlSuite.java
+++ b/src/main/org/testng/xml/XmlSuite.java
@@ -60,7 +60,7 @@
/** The suite annotation type. */
private AnnotationTypeEnum m_annotations;
- /** The suite default annotation type. */
+ /** The suite default annotation type. */
private AnnotationTypeEnum m_defaultAnnotations = VersionInfo.getDefaultAnnotationType();
/** The packages containing test classes. */
@@ -244,14 +244,14 @@
*/
public Map<String, String> getAllParameters() {
Map<String, String> result = new HashMap<String, String>();
- for (String key : m_parameters.keySet()) {
- result.put(key, m_parameters.get(key));
+ for (Map.Entry<String, String> entry : m_parameters.entrySet()) {
+ result.put(entry.getKey(), entry.getValue());
}
for (XmlTest test : getTests()) {
Map<String, String> tp = test.getParameters();
- for (String key : tp.keySet()) {
- result.put(key, tp.get(key));
+ for (Map.Entry<String, String> entry : tp.entrySet()) {
+ result.put(entry.getKey(), entry.getValue());
}
}
@@ -417,10 +417,10 @@
*/
@Override
public String toString() {
- StringBuffer result = new StringBuffer("[Suite: \"" + m_name + "\" ");
+ StringBuffer result = new StringBuffer("[Suite: \"").append( m_name).append( "\" ");
for (XmlTest t : m_tests) {
- result.append(" " + t.toString()).append(" ");
+ result.append(" ").append( t.toString()).append(' ');
}
result.append(']');
