commit 11f99f63e1405086c4f8f26048ef92e7dae269b4
author Igor Murashkin <iam@google.com> Wed Feb 24 16:21:34 2016 -0800
committer Igor Murashkin <iam@google.com> Mon Mar 21 16:22:34 2016 -0700
tree 40e1100776deb2a123af3fac5c6ace805e00c181
parent 5aa66a3827c97e22b9e79981d02f0ceb4f67ae93

XML Parser: Fix how validation is detected

Previously it was ignoring the return value, so on some
implementations like Android, it was trying to incorrectly
use validation even though it wasn't actually supported.

Bug: 27552463
Change-Id: I5872f026e4eef957a0a91c8598044152de71404a

src/main/java/org/testng/xml/XMLParser.java

diff --git a/src/main/java/org/testng/xml/XMLParser.java b/src/main/java/org/testng/xml/XMLParser.java
index 9b43997..461a9eb 100644
--- a/src/main/java/org/testng/xml/XMLParser.java
+++ b/src/main/java/org/testng/xml/XMLParser.java
@@ -95,8 +95,7 @@
    */
   private static boolean supportsValidation(SAXParserFactory spf) {
     try {
-      spf.getFeature("http://xml.org/sax/features/validation");
-      return true;
+      return spf.getFeature("http://xml.org/sax/features/validation");
     }
     catch(Exception ex) {
       return false;