commit faad219fc46032a0ae9576ccc3076612cc1f5f72
author Justin Lebar <jlebar@google.com> Fri Sep 17 19:45:35 2021 -0700
committer TensorFlower Gardener <gardener@tensorflow.org> Fri Sep 17 19:49:27 2021 -0700
tree 3ec2237bc0c1c9196a4bf7d9022c4380f3bdd5a8
parent 191144ff23f8f8ffefd8854a0f92b825642a8412

Log filecheck output to ERROR when a test fails.

This way you don't have to pass --logtostderr to see the output.

Also don't use XLA_LOG_LINES to output the filecheck results so that you can
copy-paste from your terminal without junk at the beginning of the line.

PiperOrigin-RevId: 397447111
Change-Id: I7ead4dcf1b978c7ec9bd59e1c81b747347773683

tensorflow/compiler/xla/tests/filecheck.cc

diff --git a/tensorflow/compiler/xla/tests/filecheck.cc b/tensorflow/compiler/xla/tests/filecheck.cc
index 98d27af..9a3a670 100644
--- a/tensorflow/compiler/xla/tests/filecheck.cc
+++ b/tensorflow/compiler/xla/tests/filecheck.cc
@@ -69,17 +69,17 @@
   bool succeeded = (exit_status == 0);
   auto env = tensorflow::Env::Default();
   if (!succeeded) {
-    LOG(WARNING) << "Tried to execute FileCheck at " << file_check_path;
+    LOG(ERROR) << "Tried to execute FileCheck at " << file_check_path;
     if (!env->FileExists(file_check_path).ok()) {
-      LOG(WARNING) << "NOTE: FileCheck binary does not exist!";
+      LOG(ERROR) << "NOTE: FileCheck binary does not exist!";
     }
 
-    LOG(WARNING) << "FileCheck error:\n" << standard_error;
+    // Log at ERROR level so these show up even if you don't pass --logtostderr.
+    LOG(ERROR) << "FileCheck stderr:\n" << standard_error;
+    LOG(ERROR) << "FileCheck input was:\n" << input;
   } else if (!standard_error.empty()) {
-    LOG(INFO) << "FileCheck stderr:";
-    XLA_LOG_LINES(tensorflow::INFO, standard_error);
-    LOG(INFO) << "FileCheck input was:";
-    XLA_LOG_LINES(tensorflow::INFO, input);
+    LOG(INFO) << "FileCheck stderr:\n" << standard_error;
+    LOG(INFO) << "FileCheck input was:\n" << input;
   }
   return succeeded;
 }