commit d5d64a5ff43729563785866c046f4b8a64bdc96a
author River Riddle <riverriddle@google.com> Wed Feb 06 15:21:02 2019 -0800
committer jpienaar <jpienaar@google.com> Fri Mar 29 16:19:17 2019 -0700
tree 605ed1fd1cb548444aa61b36931ec5802780d97c
parent 7fd811471d614457b32adb88dcb94cc13a7fe020

When canonicalizing only erase the operation after calling the 'fold' hook if replacement results were supplied. This fixes a bug where the operation would always get erased, even if it was modified in place.

PiperOrigin-RevId: 232757964

lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp

diff --git a/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp b/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
index 45c57e2..c2adf84 100644
--- a/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
+++ b/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
@@ -267,9 +267,9 @@
             addToWorklist(operand.getOwner());
           res->replaceAllUsesWith(resultValues[i]);
         }
-      }
 
-      op->erase();
+        op->erase();
+      }
       continue;
     }