commit a8ac8f901a3948a71510dedee258119ff4a77363
author Derek Murray <mrry@google.com> Tue Mar 03 15:02:57 2020 -0800
committer TensorFlower Gardener <gardener@tensorflow.org> Tue Mar 03 15:06:38 2020 -0800
tree 2bfafa80364e314e8c2b7648ee0d5935fd47a1b6
parent 3421416220f5dd65340f03332ff1d474de69c052

[xla::Shape::Shape] Emplace tuple shapes into `tuple_shapes_`.

This avoids creating and destroying a temporary `Shape` in `add_tuple_shapes()`, then move-assigning and destroying each tuple-shape in the constructor.

PiperOrigin-RevId: 298703231
Change-Id: I793742c163cf24780b0764aa6c3846715517f99d

tensorflow/compiler/xla/shape.cc

diff --git a/tensorflow/compiler/xla/shape.cc b/tensorflow/compiler/xla/shape.cc
index de24343..d1d5dc1 100644
--- a/tensorflow/compiler/xla/shape.cc
+++ b/tensorflow/compiler/xla/shape.cc
@@ -48,7 +48,7 @@
   }
   tuple_shapes_.reserve(shape_proto.tuple_shapes_size());
   for (const ShapeProto& element_shape : shape_proto.tuple_shapes()) {
-    *add_tuple_shapes() = Shape(element_shape);
+    tuple_shapes_.emplace_back(element_shape);
   }
   if (shape_proto.has_layout()) {
     *mutable_layout() = Layout::CreateFromProto(shape_proto.layout());