commit a53e1ae012e89833696c102022468fe0ad808604
author Jacques Pienaar <jpienaar@google.com> Thu Dec 12 14:22:40 2019 -0800
committer TensorFlower Gardener <gardener@tensorflow.org> Thu Dec 12 14:26:08 2019 -0800
tree ef6409c6c1df1c82e501072b191086da1f579bfb
parent 8929984da8a97d80a0337ffe7456639973c0311d

Fix logic on when to emit collective type but separate arg builder

Got the comment right but the code wrong :/

PiperOrigin-RevId: 285270561
Change-Id: Icaf1b1cd3c6f1edb44eac44b661b365f66ca9751

third_party/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

diff --git a/third_party/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp b/third_party/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
index a73b113..dd56458 100644
--- a/third_party/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
+++ b/third_party/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
@@ -969,7 +969,7 @@
     // Emit separate arg build with collective type, unless there is only one
     // variadic result, in which case the above would have already generated
     // the same build method.
-    if (op.getNumResults() == 1 && !op.getResult(0).isVariadic())
+    if (!(op.getNumResults() == 1 && op.getResult(0).isVariadic()))
       emit(attrType, TypeParamKind::Collective, /*inferType=*/false);
   }
 }