commit 52b2c23815f9dda0d32025d179990c0e0e84d7fd
author Thomas Joerg <tjoerg@google.com> Tue May 21 01:38:53 2019 -0700
committer Mehdi Amini <joker.eph@gmail.com> Sat Jun 01 19:53:53 2019 -0700
tree 969861a82c9faf9535a2eeb7852041cdb50a7807
parent f3c89d798f8c174d6fdcb377cac56d48deb6927b

    Small cleanup.
    * Use `cast` rather than `dyn_cast` to get an assertion failure rather than a segfault in case of a type mismatch.
    * Use stream operators to `emitOpError`s.

--

PiperOrigin-RevId: 249208135

lib/GPU/IR/GPUDialect.cpp

diff --git a/lib/GPU/IR/GPUDialect.cpp b/lib/GPU/IR/GPUDialect.cpp
index bd882c9..a7554c2 100644
--- a/lib/GPU/IR/GPUDialect.cpp
+++ b/lib/GPU/IR/GPUDialect.cpp
@@ -303,7 +303,7 @@
 }
 
 Function *LaunchFuncOp::kernel() {
-  return this->getAttr(getKernelAttrName()).dyn_cast<FunctionAttr>().getValue();
+  return this->getAttr(getKernelAttrName()).cast<FunctionAttr>().getValue();
 }
 
 unsigned LaunchFuncOp::getNumKernelOperands() {
@@ -324,20 +324,20 @@
   Function *kernelFunc = this->kernel();
   if (!kernelFunc->getAttrOfType<mlir::UnitAttr>(
           GPUDialect::getKernelFuncAttrName())) {
-    return emitError("kernel function is missing the '" +
-                     GPUDialect::getKernelFuncAttrName() + "' attribute");
+    return emitError("kernel function is missing the '")
+           << GPUDialect::getKernelFuncAttrName() << "' attribute";
   }
   unsigned numKernelFuncArgs = kernelFunc->getNumArguments();
   if (getNumKernelOperands() != numKernelFuncArgs) {
-    return emitOpError("got " + Twine(getNumKernelOperands()) +
-                       " kernel operands but expected " +
-                       Twine(numKernelFuncArgs));
+    return emitOpError("got ")
+           << getNumKernelOperands() << " kernel operands but expected "
+           << numKernelFuncArgs;
   }
   for (unsigned i = 0; i < numKernelFuncArgs; ++i) {
     if (getKernelOperand(i)->getType() !=
         kernelFunc->getArgument(i)->getType()) {
-      return emitOpError("type of function argument " + Twine(i) +
-                         " does not match");
+      return emitOpError("type of function argument ")
+             << i << " does not match";
     }
   }
   return success();