Refactor with PMD: Avoid unused method parameter 'index' in 'Composer.composeNode(Node parent, Object index)'
diff --git a/pom.xml b/pom.xml
index f936946..c62bcdf 100644
--- a/pom.xml
+++ b/pom.xml
@@ -306,6 +306,16 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-pmd-plugin</artifactId>
<version>2.6</version>
+ <configuration>
+ <linkXref>true</linkXref>
+ <sourceEncoding>utf-8</sourceEncoding>
+ <minimumTokens>100</minimumTokens>
+ <targetJdk>1.5</targetJdk>
+ <excludes>
+ <!--exclude>**/*Bean.java</exclude-->
+ <exclude>**/external/*.java</exclude>
+ </excludes>
+ </configuration>
</plugin>
</plugins>
</reporting>
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index d818d5c..d15165a 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -8,6 +8,11 @@
<body>
<release version="1.10-SNAPSHOT" date="in Mercurial" description="Development">
<action dev="py4fun" type="update">
+ Refactor with PMD: Composer - Avoid unused method parameter 'index' in
+ 'Composer.composeNode(Node parent, Object index)''. It was used
+ in PyYAML for kind of XPath for YAML, but it was not imported from PyYAML (2012-01-28)
+ </action>
+ <action dev="py4fun" type="update">
Refactor Emitter: the SPACE mutable static field could be changed by malicious code or by accident.
Boxed value is unboxed and then immediately reboxed (2012-01-28)
</action>
diff --git a/src/main/java/org/yaml/snakeyaml/composer/Composer.java b/src/main/java/org/yaml/snakeyaml/composer/Composer.java
index 635abe4..2972716 100644
--- a/src/main/java/org/yaml/snakeyaml/composer/Composer.java
+++ b/src/main/java/org/yaml/snakeyaml/composer/Composer.java
@@ -119,7 +119,7 @@
// Drop the DOCUMENT-START event.
parser.getEvent();
// Compose the root node.
- Node node = composeNode(null, null);
+ Node node = composeNode(null);
// Drop the DOCUMENT-END event.
parser.getEvent();
this.anchors.clear();
@@ -127,7 +127,7 @@
return node;
}
- private Node composeNode(Node parent, Object index) {
+ private Node composeNode(Node parent) {
recursiveNodes.add(parent);
if (parser.checkEvent(Event.ID.Alias)) {
AliasEvent event = (AliasEvent) parser.getEvent();
@@ -201,7 +201,7 @@
}
int index = 0;
while (!parser.checkEvent(Event.ID.SequenceEnd)) {
- children.add(composeNode(node, index));
+ children.add(composeNode(node));
index++;
}
Event endEvent = parser.getEvent();
@@ -228,13 +228,13 @@
anchors.put(anchor, node);
}
while (!parser.checkEvent(Event.ID.MappingEnd)) {
- Node itemKey = composeNode(node, null);
+ Node itemKey = composeNode(node);
if (itemKey.getTag().equals(Tag.MERGE)) {
node.setMerged(true);
} else if (itemKey.getTag().equals(Tag.VALUE)) {
itemKey.setTag(Tag.STR);
}
- Node itemValue = composeNode(node, itemKey);
+ Node itemValue = composeNode(node);
children.add(new NodeTuple(itemKey, itemValue));
}
Event endEvent = parser.getEvent();
