Clamp lighting dot product in paint_alpha_normals_rt
Fixes inconsistent results in other color types/spaces, where the output
can be negative.
Change-Id: I8a346cf7bb02cb298c11d658948c117d74b6ddaa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/469359
Auto-Submit: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
diff --git a/gm/runtimeshader.cpp b/gm/runtimeshader.cpp
index 7e78f53..c4b24ea 100644
--- a/gm/runtimeshader.cpp
+++ b/gm/runtimeshader.cpp
@@ -675,7 +675,7 @@
half4 main(vec2 p) {
vec3 n = normalize(normals.eval(p).xyz * 2 - 1);
vec3 l = normalize(vec3(1, -1, 1));
- return dot(n, l).xxx1;
+ return saturate(dot(n, l)).xxx1;
}
)";
auto effect = SkRuntimeEffect::MakeForShader(SkString(kSrc)).effect;
