commit e63c5c9f6752244ca0f39075fa148a0281593831
author Mike Reed <reed@google.com> Fri Mar 19 10:36:23 2010 -0400
committer Mike Reed <reed@google.com> Fri Mar 19 10:36:23 2010 -0400
tree 7b0bb1652e5f4b1dbb5ad0327ff0345c080064c2
parent d2d74d6d9f6bc7c5a88dd7e4e6087d482bd103dd

use 64bit intermediate to accumulate 16.16 advances, to avoid overflow

fixes http://b/issue?id=2422924

Change-Id: Ia3abd981f7f5954204517880e69d44125dcaadb5

src/core/SkPaint.cpp

diff --git a/src/core/SkPaint.cpp b/src/core/SkPaint.cpp
index a013412..3d85b8c 100644
--- a/src/core/SkPaint.cpp
+++ b/src/core/SkPaint.cpp
@@ -711,9 +711,24 @@
                 SkIntToScalar(g.fTop + g.fHeight));
 }
 
-static void join_bounds(const SkGlyph& g, SkRect* bounds, SkFixed dx)
+// 64bits wide, with a 16bit bias. Useful when accumulating lots of 16.16 so
+// we don't overflow along the way
+typedef int64_t Sk48Dot16;
+
+#ifdef SK_SCALAR_IS_FLOAT
+    static inline float Sk48Dot16ToScalar(Sk48Dot16 x) {
+        return x * 1.5258789e-5f;   // x * (1 / 65536.0f)
+    }
+#else
+    static inline SkFixed Sk48Dot16ToScalar(Sk48Dot16 x) {
+        // just return the low 32bits
+        return static_cast<SkFixed>(x);
+    }
+#endif
+
+static void join_bounds(const SkGlyph& g, SkRect* bounds, Sk48Dot16 dx)
 {
-    SkScalar sx = SkFixedToScalar(dx);
+    SkScalar sx = Sk48Dot16ToScalar(dx);
     bounds->join(SkIntToScalar(g.fLeft) + sx,
                  SkIntToScalar(g.fTop),
                  SkIntToScalar(g.fLeft + g.fWidth) + sx,
@@ -740,7 +755,10 @@
     int         n = 1;
     const char* stop = (const char*)text + byteLength;
     const SkGlyph* g = &glyphCacheProc(cache, &text);
-    SkFixed x = g->fAdvanceX;
+    // our accumulated fixed-point advances might overflow 16.16, so we use
+    // a 48.16 (64bit) accumulator, and then convert that to scalar at the
+    // very end.
+    Sk48Dot16 x = g->fAdvanceX;
 
     SkAutoKern  autokern;
 
@@ -788,7 +806,7 @@
     SkASSERT(text == stop);
 
     *count = n;
-    return SkFixedToScalar(x);
+    return Sk48Dot16ToScalar(x);
 }
 
 SkScalar SkPaint::measureText(const void* textData, size_t length,
@@ -898,8 +916,9 @@
     SkMeasureCacheProc glyphCacheProc = this->getMeasureCacheProc(tbd, false);
     const char*      stop;
     SkTextBufferPred pred = chooseTextBufferPred(tbd, &text, length, &stop);
-    SkFixed          max = SkScalarToFixed(maxWidth);
-    SkFixed          width = 0;
+    // use 64bits for our accumulator, to avoid overflowing 16.16
+    Sk48Dot16        max = SkScalarToFixed(maxWidth);
+    Sk48Dot16        width = 0;
 
     SkAutoKern  autokern;
 
@@ -938,7 +957,7 @@
     if (measuredWidth)
     {
         
-        SkScalar scalarWidth = SkFixedToScalar(width);
+        SkScalar scalarWidth = Sk48Dot16ToScalar(width);
         if (scale)
             scalarWidth = SkScalarMul(scalarWidth, scale);
         *measuredWidth = scalarWidth;