commit 9be2676bc4e595bb7799c89370e99d9663da8c4b
author John Stiles <johnstiles@google.com> Wed Nov 16 10:42:36 2022 -0500
committer SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> Wed Nov 16 16:50:22 2022 +0000
tree 27b8046230f2cf85e8d57bf440cb9be9514a4660
parent 74a57221dfb310d7802fec1d99ee083d065d4471

Omit frame pointers in SkOpts code.

This has a huge impact the generated code for each SkRasterPipeline
op (all tail-call based).

Change-Id: I3d77ef342a42292bb6bfa7a68e157c85d1e2a1a9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/606576
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 002a02c..4c8c011 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -184,6 +184,14 @@
     defines = [ "SK_CPU_SSE_LEVEL=SK_CPU_SSE_LEVEL_SSSE3" ]
   } else {
     cflags = [ "-mssse3" ]
+    if (!is_win) {
+      cflags += [
+        "-fomit-frame-pointer",
+        "-momit-leaf-frame-pointer",
+      ]
+    } else {
+      cflags += [ "/Oy-" ]
+    }
   }
 }
 
@@ -194,6 +202,14 @@
     defines = [ "SK_CPU_SSE_LEVEL=SK_CPU_SSE_LEVEL_SSE42" ]
   } else {
     cflags = [ "-msse4.2" ]
+    if (!is_win) {
+      cflags += [
+        "-fomit-frame-pointer",
+        "-momit-leaf-frame-pointer",
+      ]
+    } else {
+      cflags += [ "/Oy-" ]
+    }
   }
 }
 
@@ -204,6 +220,14 @@
     cflags = [ "/arch:AVX" ]
   } else {
     cflags = [ "-mavx" ]
+    if (!is_win) {
+      cflags += [
+        "-fomit-frame-pointer",
+        "-momit-leaf-frame-pointer",
+      ]
+    } else {
+      cflags += [ "/Oy-" ]
+    }
     if (is_mac && is_debug) {
       cflags += [ "-fno-stack-check" ]  # Work around skia:9709
     }
@@ -217,6 +241,14 @@
     cflags = [ "/arch:AVX2" ]
   } else {
     cflags = [ "-march=haswell" ]
+    if (!is_win) {
+      cflags += [
+        "-fomit-frame-pointer",
+        "-momit-leaf-frame-pointer",
+      ]
+    } else {
+      cflags += [ "/Oy-" ]
+    }
     if (is_mac && is_debug) {
       cflags += [ "-fno-stack-check" ]  # Work around skia:9709
     }
@@ -230,6 +262,14 @@
     cflags = [ "/arch:AVX512" ]
   } else {
     cflags = [ "-march=skylake-avx512" ]
+    if (!is_win) {
+      cflags += [
+        "-fomit-frame-pointer",
+        "-momit-leaf-frame-pointer",
+      ]
+    } else {
+      cflags += [ "/Oy-" ]
+    }
     if (is_mac && is_debug) {
       cflags += [ "-fno-stack-check" ]  # Work around skia:9709
     }