commit 7a671982cd89e605159bacb81b653da2d086490c
author Mike Klein <mtklein@google.com> Wed Dec 04 14:41:08 2019 -0600
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Wed Dec 04 21:14:13 2019 +0000
tree e31e361d0f53d804a5350493ecec2789fe1437fb
parent 8c78ce67b5a7910868565bdd8c0c7ba8434570a0

work around GCC 8 mips release bug?

This feels kind of bad, but at least it's just a unit test?

Change-Id: I18740f846680218a00add40eb2398876c4fd19be
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258023
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>

tests/WindowRectanglesTest.cpp

diff --git a/tests/WindowRectanglesTest.cpp b/tests/WindowRectanglesTest.cpp
index 8a91130..0d78b44 100644
--- a/tests/WindowRectanglesTest.cpp
+++ b/tests/WindowRectanglesTest.cpp
@@ -50,12 +50,14 @@
         B.addWindow(SkRectPriv::MakeILarge());
         REPORTER_ASSERT(reporter, B != A);
 
-        REPORTER_ASSERT(reporter, !memcmp(A.data(), windowData,
-                                          GrWindowRectangles::kMaxWindows * sizeof(SkIRect)));
-        REPORTER_ASSERT(reporter, !memcmp(B.data(), windowData,
-                                          (GrWindowRectangles::kMaxWindows - 1) * sizeof(SkIRect)));
-        REPORTER_ASSERT(reporter,
-                        B.data()[GrWindowRectangles::kMaxWindows - 1] == SkRectPriv::MakeILarge());
+        for (int i = 0; i < GrWindowRectangles::kMaxWindows - 1; i++) {
+            REPORTER_ASSERT(reporter, A.data()[i] == windowData[i]);
+            REPORTER_ASSERT(reporter, B.data()[i] == windowData[i]);
+        }
+        REPORTER_ASSERT(reporter, A.data()[GrWindowRectangles::kMaxWindows - 1]
+                             == windowData[GrWindowRectangles::kMaxWindows - 1]);
+        REPORTER_ASSERT(reporter, B.data()[GrWindowRectangles::kMaxWindows - 1]
+                             == SkRectPriv::MakeILarge());
     }
     {
         GrWindowRectangles A(wr), B(wr);
@@ -66,9 +68,10 @@
         B.addWindow(windowData[GrWindowRectangles::kMaxWindows - 1]);
         REPORTER_ASSERT(reporter, B == A);
         REPORTER_ASSERT(reporter, B.data() != A.data());
-        REPORTER_ASSERT(reporter, !memcmp(B.data(), A.data(),
-                                          GrWindowRectangles::kMaxWindows * sizeof(SkIRect)));
-        REPORTER_ASSERT(reporter, !memcmp(A.data(), windowData,
-                                          GrWindowRectangles::kMaxWindows * sizeof(SkIRect)));
+
+        for (int i = 0; i < GrWindowRectangles::kMaxWindows; i++) {
+            REPORTER_ASSERT(reporter, B.data()[i] ==   A.data()[i]);
+            REPORTER_ASSERT(reporter, A.data()[i] == windowData[i]);
+        }
     }
 }