commit 616b4a6e638d6c9a6d5e70cdf8f1ef4bead36a2b
author Chris Dalton <csmartdalton@google.com> Fri Nov 19 16:43:26 2021 -0700
committer SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> Mon Nov 22 16:54:38 2021 +0000
tree 0e770aac4c3b692163166a8168db1a6b9749755b
parent e6f2dce084da2d35092cde21d400e686ddef170e

Drop support for indirect draws on ES

Bug: skia:b/197500792
Change-Id: I0005469352cd44cf4c66aea11de98a0247afd747
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474397
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>

src/gpu/gl/GrGLCaps.cpp

diff --git a/src/gpu/gl/GrGLCaps.cpp b/src/gpu/gl/GrGLCaps.cpp
index d7e5936..64a76c0 100644
--- a/src/gpu/gl/GrGLCaps.cpp
+++ b/src/gpu/gl/GrGLCaps.cpp
@@ -680,11 +680,12 @@
             fUseClientSideIndirectBuffers = true;
         } else {
             fBaseVertexBaseInstanceSupport = ctxInfo.hasExtension("GL_EXT_base_instance");
-            if (fBaseVertexBaseInstanceSupport) {
-                fNativeDrawIndirectSupport = (version >= GR_GL_VER(3,1));
-                // Don't use GL_EXT_multi_draw_indirect. It doesn't allow VAO 0.
-                // https://github.com/KhronosGroup/OpenGL-Registry/blob/main/extensions/EXT/EXT_multi_draw_indirect.txt#L142
-            }
+            // Don't support indirect draws on ES. They don't allow VAO 0.
+            //
+            // "An INVALID_OPERATION error is generated if zero is bound to VERTEX_ARRAY_BINDING,
+            // DRAW_INDIRECT_BUFFER or to any enabled vertex array."
+            //
+            // https://www.khronos.org/registry/OpenGL/specs/es/3.1/es_spec_3.1.pdf
         }
         fDrawRangeElementsSupport = version >= GR_GL_VER(3,0);
     } else if (GR_IS_GR_WEBGL(standard)) {