commit 034ef7b99c25deb3f51f7c1b8a7946f59cc333ed
author Googler <noreply@google.com> Mon Dec 16 02:21:25 2019 -0800
committer Copybara Robolectric Bot <copybara-robolectric@google.com> Mon Dec 16 02:22:02 2019 -0800
tree 41c6a4122ca6dc13e73548d68b465ad5c4a0ef8e
parent cab549a0cdfc60c4d291e6cb16c3e2998848ccfb

Don't explicitly call ContentProvider.onCreate() during initialization

ContentProvider.attachInfo() already calls onCreate(), so this allows content providers to do non-idempotent initialization.

PiperOrigin-RevId: 285730764

shadows/framework/src/main/java/org/robolectric/shadows/ShadowContentResolver.java

diff --git a/shadows/framework/src/main/java/org/robolectric/shadows/ShadowContentResolver.java b/shadows/framework/src/main/java/org/robolectric/shadows/ShadowContentResolver.java
index 03ee01d..a936175 100644
--- a/shadows/framework/src/main/java/org/robolectric/shadows/ShadowContentResolver.java
+++ b/shadows/framework/src/main/java/org/robolectric/shadows/ShadowContentResolver.java
@@ -885,7 +885,6 @@
       ContentProvider provider =
           (ContentProvider) Class.forName(providerInfo.name).getDeclaredConstructor().newInstance();
       provider.attachInfo(RuntimeEnvironment.application, providerInfo);
-      provider.onCreate();
       return provider;
     } catch (InstantiationException
         | ClassNotFoundException