blob: eb0d9147db438f9d0e5f4c7b2f125e9fcb8e9f76 [file] [log] [blame]
#include <c10d/default_comm_hooks.hpp>
#include <c10d/reducer.hpp>
#include <functional>
#include <c10/core/DeviceGuard.h>
#include <c10/core/StreamGuard.h>
#include <c10/util/Exception.h>
#include <c10/util/hash.h>
#include <c10/util/irange.h>
#include <c10d/comm.hpp>
#include <c10d/logger.hpp>
#include <torch/csrc/autograd/engine.h>
#include <torch/csrc/autograd/function_hook.h>
#include <torch/csrc/autograd/functions/accumulate_grad.h>
#include <torch/csrc/autograd/profiler.h>
#include <torch/csrc/autograd/utils/grad_layout_contract.h>
#include <torch/csrc/autograd/utils/lambda_post_hook.h>
#include <torch/csrc/utils/memory.h>
namespace c10d {
namespace {
inline int64_t current_time_in_nanos() {
return torch::autograd::profiler::getTime();
}
constexpr int kUnsetDivFactor = -1;
// Macro that wraps TORCH_CHECK with DDP logging.
#define REDUCER_CHECK(cond, logger_, ...) \
if (C10_UNLIKELY_OR_CONST(!(cond))) { \
if (!logger_.expired()) { \
logger_.lock()->set_error_and_log(__VA_ARGS__); \
} \
TORCH_CHECK(false, ##__VA_ARGS__); \
}
} // namespace
C10_DEFINE_TYPED_REGISTRY( // NOLINT
TimerRegistry,
c10::DeviceType,
Timer,
std::unique_ptr,
c10::Device);
namespace {
class CpuTimer : public Timer {
private:
// The timestamp of forward call start time in each iteration.
int64_t forward_start_time = -1;
// The timestamp of backward computation start and end time in each
// iteration.
int64_t backward_compute_start_time = -1;
int64_t backward_compute_end_time = -1;
// The timestamp of first communication call start time in each iteration.
int64_t backward_comm_start_time = -1;
// The timestamp of last communication call end time in each iteration.
int64_t backward_comm_end_time = -1;
int64_t& getTime(Event event) {
switch (event) {
case Event::kForwardStart:
return forward_start_time;
case Event::kBackwardComputeStart:
return backward_compute_start_time;
case Event::kBackwardComputeEnd:
return backward_compute_end_time;
case Event::kBackwardCommStart:
return backward_comm_start_time;
case Event::kBackwardCommEnd:
return backward_comm_end_time;
default:
TORCH_INTERNAL_ASSERT(false);
}
}
public:
explicit CpuTimer(c10::Device /* unused */) {}
void record(Event event) override {
getTime(event) = current_time_in_nanos();
}
c10::optional<int64_t> measureDifference(Event start, Event end) override {
int64_t start_time = getTime(start);
int64_t end_time = getTime(end);
// If cpu_end_time is not recorded in this iteration,
// avg_time will return invalid value.
// For some cases like DDP runs on non-sync mode, backward compute
// end time can not be recorded in this iteration and thus can not
// calculate the valid avg_time.
// In this case, skip calculating the avg_time and return.
if (end_time < start_time) {
return c10::nullopt;
}
return end_time - start_time;
}
};
C10_REGISTER_TYPED_CLASS(TimerRegistry, c10::kCPU, CpuTimer);
} // namespace
Reducer::Reducer(
std::vector<std::vector<at::Tensor>> replicas,
std::vector<std::vector<size_t>> bucket_indices,
c10::intrusive_ptr<c10d::ProcessGroup> process_group,
std::vector<std::vector<bool>> expect_sparse_gradients,
int64_t bucket_bytes_cap,
bool find_unused_parameters,
bool gradient_as_bucket_view,
std::unordered_map<size_t, std::string> paramNames)
: replicas_(std::move(replicas)),
process_group_(std::move(process_group)),
expect_sparse_gradients_(std::move(expect_sparse_gradients)),
expect_autograd_hooks_(false),
require_finalize_(false),
next_bucket_(0),
has_marked_unused_parameters_(false),
find_unused_parameters_(find_unused_parameters),
gradient_as_bucket_view_(gradient_as_bucket_view),
local_used_maps_reduced_(false),
num_iterations_(0),
num_buckets_ready_(0),
has_rebuilt_bucket_(false),
bucket_bytes_cap_(bucket_bytes_cap),
div_factor_(kUnsetDivFactor),
static_graph_(false),
comm_hook_(nullptr),
thread_local_state_(at::ThreadLocalState()),
ddp_debug_level_(parseDistDebugLevel()),
param_names_(std::move(paramNames)) {
C10_LOG_API_USAGE_ONCE("torch.distributed.ddp.reducer");
TORCH_INTERNAL_ASSERT(
replicas_.size() == 1, "Expected exactly one model replica.");
TORCH_INTERNAL_ASSERT(
replicas_[0].size() >= 1, "Expected at least one parameter.");
// Check whether the module is multi_device_module
{
std::set<int> unique_devices;
for (const auto& v : replicas_[0]) {
auto device_idx = int(v.device().index());
if (unique_devices.find(device_idx) == unique_devices.end()) {
unique_devices.insert(device_idx);
if (unique_devices.size() > 1) {
is_multi_device_module_ = true;
break;
}
}
}
}
// For CUDA, record events only for single device module.
c10::Device device = replicas_[0][0].device();
if (!(device.is_cuda() && is_multi_device_module_)) {
timer_ = TimerRegistry()->Create(device.type(), device);
}
// If `expect_sparse_gradients` is not specified, initialize it such that
// we do not expect sparse gradients for any parameter.
if (expect_sparse_gradients_.empty()) {
expect_sparse_gradients_ = std::vector<std::vector<bool>>(
replicas_.size(), std::vector<bool>(replicas_[0].size(), false));
}
TORCH_INTERNAL_ASSERT(expect_sparse_gradients_.size() == replicas_.size());
// Initialize variable bucketing.
// This can be reinitialized later after capturing runtime information.
{
std::lock_guard<std::mutex> lock(mutex_);
initialize_buckets(std::move(bucket_indices));
}
// All variables are expected to have their `grad_fn` set to the gradient
// accumulation function (since they are leafs in the autograd graph).
// We store pointers to these functions such that we can check if they are
// used in an autograd pass. If they are not, we know their grad tensors
// can be marked as ready for reduction.
{
const auto replica_count = replicas_.size();
grad_accumulators_.resize(replica_count);
// TODO: get rid of replica_index and nested
// containers such as replicas_, grad_accumulators_, etc.
size_t replica_index = 0;
const auto variable_count = replicas_[replica_index].size();
grad_accumulators_[replica_index].resize(variable_count);
for (const auto variable_index : c10::irange(variable_count)) {
auto& variable = replicas_[replica_index][variable_index];
// The gradient accumulator function is lazily initialized once.
// Therefore we can use its presence in the autograd graph as
// evidence that the parameter has participated in an iteration.
auto grad_accumulator = torch::autograd::impl::grad_accumulator(variable);
#ifndef _WIN32
using torch::distributed::autograd::ThreadLocalDistAutogradContext;
#endif
// Hook to execute after the gradient accumulator has executed.
hooks_.emplace_back(
grad_accumulator->add_post_hook(
torch::make_unique<torch::autograd::utils::LambdaPostHook>(
[=](const torch::autograd::variable_list& outputs,
const torch::autograd::variable_list& /* unused */) {
#ifndef _WIN32
this->rpc_context_.set(
ThreadLocalDistAutogradContext::getContextPtr());
#endif
this->autograd_hook(variable_index);
return outputs;
})),
grad_accumulator);
// Map raw function pointer to replica index and parameter index.
// This is used later on when the autograd graph is traversed
// to check for parameters for which no gradient is computed, if
// find_unused_parameters=True.
// Note that the mapping of gradient accumulator to variable should be
// one to one as we deduplicate shared parameters before constructing
// Reducer.
if (find_unused_parameters_) {
gradAccToVariableMap_[grad_accumulator.get()] = variable_index;
}
numGradHooksTriggeredMap_[variable_index] = 0;
// The gradient accumulator is stored as weak_ptr in the autograd
// metadata of the variable, so we have to keep it alive here for
// the raw pointer to be valid.
REDUCER_CHECK(
grad_accumulators_[replica_index][variable_index] == nullptr,
logger_,
c10::str(
"Reducer tried to register duplicate grad accumulator for replica ",
replica_index,
" variable ",
variable_index));
grad_accumulators_[replica_index][variable_index] =
std::move(grad_accumulator);
}
}
// Initialize backward stats vector.
{
const auto replica_count = replicas_.size();
backward_stats_.resize(replica_count);
const auto variable_count = replicas_[0].size();
std::for_each(
backward_stats_.begin(),
backward_stats_.end(),
[=](std::vector<int64_t>& v) { v.resize(variable_count); });
}
// See Note [Skip allreducing local_used_maps_dev]
if (find_unused_parameters_) {
initialize_local_used_map();
}
}
// Note [Skip allreducing local_used_maps_dev]
// ~~~~~~~~~~~~~~~~~~~~~~~~~~
// If find_unused_parameters_ is set to false, there is no need to allreduce
// local_used_maps_dev_, because all parameters will be reduced anyway.
// Therefore, we can avoid allocating memory for local_used_maps and
// local_used_maps_dev_ if find_unused_parameters_ is false.
// Note [DDP Communication Hook]
// ~~~~~~~~~~~~~~~~~~~~~~~~~~
// If DDP communication hook is not registered, the reducer reduces the buckets
// by just calling allreduce. If registered, it calls the hook and uses future
// work handle. If registered, reducer also skips dividing grads by world size.
// The reason for this is that the communication hook is expected to completely
// override how we perform communication and the user should have complete
// control over how the grads are handled.
//
// DDP communication hook is an enhancement that provides a hook which can be
// used to override how DDP communicates gradients across ranks, this can be
// used for algorithms like Gradient Compression/GossipGrad. This hook can be
// registered from Python API using `register_comm_hook`. `PythonCommHook`
// enables registering a Python hook and is a subclass of `CommHookInterface`.
// Additionally, there are also some built-in C++ hook implementations that can
// be specified by calling `register_builtin_comm_hook` from Python API.
Reducer::~Reducer() noexcept(false) {
// Remove all hooks on variables registered by this Reducer. This is necessary
// to make DDP failure recoverable. Otherwise, multiple Reducer instances
// (from recoveries) will add their hooks to the original model, and those
// hooks will try to invoke methods on a deleted Reducer objects.
for (auto& hook : hooks_) {
auto& key = hook.first;
auto& grad_accumulator = hook.second;
TORCH_INTERNAL_ASSERT(
grad_accumulator->del_post_hook(key),
"Reducer attempts to delete a non-existing hook.");
}
}
bool Reducer::dynamic_graph_find_unused() {
return !static_graph_ && find_unused_parameters_;
}
bool Reducer::static_graph_first_iteration() {
return static_graph_ && num_iterations_ == 1;
}
bool Reducer::static_graph_after_first_iteration() {
return static_graph_ && num_iterations_ > 1;
}
void Reducer::initialize_local_used_map() {
const auto replica_count = replicas_.size();
const auto variable_count = replicas_[0].size();
local_used_maps_.resize(replica_count);
local_used_maps_dev_.resize(replica_count);
for (const auto i : c10::irange(replica_count)) {
at::TensorOptions options;
options = options.dtype(at::kInt);
// Deliberately don't pin the memory even if local_used_maps_dev_ will
// be cuda. See Note [local_used_maps_ -> local_used_maps_dev copying]
local_used_maps_[i] =
at::zeros({static_cast<long>(variable_count)}, options);
// This tensor needs to be on the same device as replica because backend
// such as NCCL may not support CPU tensors, and hence it might not work
// if we always put it on CPU.
options = options.device(replicas_[i][0].device());
local_used_maps_dev_[i] =
at::empty({static_cast<long>(variable_count)}, options);
}
}
void Reducer::check_grad_layout(
const at::Tensor& grad,
const at::Tensor& bucket_view) {
// Ensure that the gradient type matches the bucket type.
REDUCER_CHECK(
grad.options().type_equal(bucket_view.options()),
logger_,
c10::str("Expected ", bucket_view.toString(), ", got ", grad.toString()));
TORCH_INTERNAL_ASSERT(grad.device() == bucket_view.device());
TORCH_INTERNAL_ASSERT(grad.numel() == bucket_view.numel());
// AccumulateGrad doesn't HAVE to obey the grad layout contract.
// The penalty for disobedience is reduced performance, not numerical
// death. Warnings here help diagnose poor DDP performance.
if (grad.strides() != bucket_view.strides()) {
TORCH_WARN_ONCE(
"Grad strides do not match bucket view strides. "
"This may indicate grad was not created according to the "
"gradient layout contract, or that the param's strides "
"changed since DDP was constructed. This is not an error, "
"but may impair performance.\n"
"grad.sizes() = ",
grad.sizes(),
", strides() = ",
grad.strides(),
"\n",
"bucket_view.sizes() = ",
bucket_view.sizes(),
", strides() = ",
bucket_view.strides());
}
if (!gradient_as_bucket_view_) {
TORCH_INTERNAL_ASSERT(!grad.is_alias_of(bucket_view));
}
}
void Reducer::mark_variable_ready_dense(size_t variable_index) {
const auto replica_index = 0;
const auto& bucket_index = variable_locators_[variable_index];
auto& bucket = buckets_[bucket_index.bucket_index];
auto& replica = bucket.replicas[replica_index];
auto& variable = replica.variables[bucket_index.intra_bucket_index];
auto& bucket_view = replica.bucket_views_in[bucket_index.intra_bucket_index];
// Copy contents of gradient tensor to bucket tensor.
// If the gradient is not set, we assume it wasn't computed
// as part of the current backwards pass, and zero the part
// of the bucket it would otherwise hold.
runGradCallbackForVariable(variable, [&](auto& grad) {
if (grad.defined()) {
this->check_grad_layout(grad, bucket_view);
// When gradient_as_bucket_view_ is false, or even when
// gradient_as_bucket_view_ is true, in rare cases users may set grad to
// be None after every iteration. In these cases, grad and bucket_view are
// pointing to different storages and thus need to copy grads to
// bucket_view. If gradient_as_bucket_view_ is set as true, let grad point
// to bucket_view. If grad has already been set as views of buckets in
// previous iterations, no copy is needed.
if (!grad.is_alias_of(bucket_view)) {
if (comm_hook_ == nullptr) {
auto wrapped =
at::native::wrapped_scalar_tensor(double(1.) / div_factor_);
// Divides while copying into the bucket view to save one scan over
// all the input parameters.
at::mul_out(bucket_view, grad, wrapped);
} else {
bucket_view.copy_(grad);
}
if (gradient_as_bucket_view_) {
// Let grad point to bucket_view buffer.
grad = bucket_view;
// The grad is modified and need to be written back.
return true;
}
} else {
// If grad and bucket view point to the same storage, no need to copy.
if (comm_hook_ == nullptr) {
bucket_view.div_(div_factor_);
}
}
} else {
bucket_view.zero_();
}
// The grad is not modified and doesn't need to be written back.
return false;
});
}
void Reducer::mark_variable_ready_sparse(size_t variable_index) {
const auto replica_index = 0;
const auto& bucket_index = variable_locators_[variable_index];
auto& bucket = buckets_[bucket_index.bucket_index];
auto& replica = bucket.replicas[replica_index];
auto& variable = replica.variables[bucket_index.intra_bucket_index];
runGradCallbackForVariable(variable, [&](auto& grad) {
REDUCER_CHECK(
grad.defined(), logger_, "Expected sparse gradient to be defined.");
REDUCER_CHECK(
grad.options().layout() == c10::kSparse,
logger_,
"Expected variable to have sparse gradient.");
// Sparse tensors cannot be grouped together with other sparse tensors
// in a single reduction operation like we can for dense tensors.
// Therefore, the `offsets` and `lengths` vectors in the bucket replica
// struct are empty, and there is no pre-existing accumulation tensor.
// Directly assign the sparse tensor to the `contents` field.
replica.contents = grad;
// If no DDP comm hook is registered,
// the allreduce only sums up the value, and a separate division is
// required.
if (comm_hook_ == nullptr) {
replica.contents.div_(div_factor_);
}
// The grad is modified in place and needs to be written back.
return true;
});
}
std::vector<c10d::GradBucket> Reducer::get_grad_buckets(
bool return_zero_tensors) const {
std::lock_guard<std::mutex> lock(mutex_);
std::vector<c10d::GradBucket> gradBuckets;
gradBuckets.reserve(buckets_.size());
for (size_t i = 0; i < buckets_.size(); ++i) {
auto& bucket = buckets_[i];
auto variables_for_bucket = get_variables_for_bucket(i, bucket);
gradBuckets.emplace_back(
i,
return_zero_tensors ? at::zeros_like(bucket.replicas[0].contents)
: bucket.replicas[0].contents,
bucket.replicas[0].offsets,
bucket.replicas[0].lengths,
bucket.replicas[0].sizes_vec,
variables_for_bucket);
}
return gradBuckets;
}
void Reducer::set_forward_pass_work_handle(
c10::intrusive_ptr<c10d::ProcessGroup::Work> forwardPassWorkHandle,
bool useStaticWorldSize) {
std::lock_guard<std::mutex> lock(mutex_);
forwardPassWorkHandle_.workHandle = std::move(forwardPassWorkHandle);
forwardPassWorkHandle_.useStaticWorldSize = useStaticWorldSize;
}
std::vector<at::Tensor> Reducer::get_local_used_maps_on_device() const {
std::lock_guard<std::mutex> lock(mutex_);
return local_used_maps_dev_;
}
void Reducer::push_rebuilt_params_for_all_indices() {
std::lock_guard<std::mutex> lock(mutex_);
if (!should_rebuild_buckets() || !rebuilt_param_indices_.empty()) {
return;
}
const auto replica_count = replicas_.size();
const auto variable_count = replicas_[0].size();
for (const auto variable_index : c10::irange(variable_count)) {
push_rebuilt_params(variable_index);
}
}
void Reducer::push_rebuilt_params(const size_t& index) {
rebuilt_params_.push_back(replicas_[0][index]);
rebuilt_param_indices_.push_back(index);
}
void Reducer::set_divide_factor() {
// If it was scheduled, wait on allreduce in forward pass that tells us
// division factor based on no. of currently participating processes.
if (div_factor_ == kUnsetDivFactor) {
div_factor_ = process_group_->getSize();
auto& workHandle = forwardPassWorkHandle_.workHandle;
if (workHandle && !forwardPassWorkHandle_.useStaticWorldSize) {
workHandle->wait();
auto results = workHandle->result();
// Guard against the results being empty
TORCH_INTERNAL_ASSERT(results.size() > 0);
at::Tensor& res = results.front();
div_factor_ = res.item().to<int>();
}
}
}
// Right now delay_all_reduce is only called when static_graph_=true and
// num_iterations_==1.
void Reducer::delay_all_reduce() {
std::lock_guard<std::mutex> lock(this->mutex_);
if (should_collect_runtime_stats()) {
record_backward_compute_end_time();
record_backward_comm_start_time();
}
// launch all reduce local used map
all_reduce_local_used_map();
// prepare to set unused_parameters_, if it is static graph,
// unused_parameters_ will not change after 1st iteration.
unused_parameters_.clear();
// copy all gradients to buckets
size_t replica_index = 0;
for (size_t variable_index = 0;
variable_index < replicas_[replica_index].size();
variable_index++) {
// set unused_parameters_
if (numGradHooksTriggeredMap_[variable_index] == 0) {
unused_parameters_.push_back(variable_index);
}
require_finalize_ = true;
set_divide_factor();
if (expect_sparse_gradients_[replica_index][variable_index]) {
mark_variable_ready_sparse(variable_index);
} else {
mark_variable_ready_dense(variable_index);
}
}
// launch all reduces for all buckets
for (auto& bucket : buckets_) {
all_reduce_bucket(bucket);
}
finalize_backward();
}
void Reducer::set_logger(std::weak_ptr<c10d::Logger> logger) {
logger_ = logger;
}
// The function `autograd_hook` is called after the gradient for a
// model parameter has been accumulated into its gradient tensor.
// This function is only to be called from the autograd thread.
void Reducer::autograd_hook(size_t index) {
std::lock_guard<std::mutex> lock(this->mutex_);
// Carry over thread local state from main thread. This allows for
// thread-local flags such as profiler enabled to be configure correctly.
at::ThreadLocalStateGuard g(thread_local_state_);
// Ignore if we don't expect to be called.
// This may be the case if the user wants to accumulate gradients
// for number of iterations before reducing them.
if (!expect_autograd_hooks_) {
return;
}
// See Note [Skip allreducing local_used_maps_dev]
if (dynamic_graph_find_unused() || static_graph_first_iteration()) {
// Since it gets here, this param has been used for this iteration. We want
// to mark it in local_used_maps_. During no_sync session, the same var can
// be set multiple times, which is OK as does not affect correctness. As
// long as it is used once during no_sync session, it is marked as used.
local_used_maps_[0][index] = 1;
}
if (static_graph_first_iteration()) {
numGradHooksTriggeredMap_[index] += 1;
return;
}
// If `find_unused_parameters_` is true there may be model parameters that
// went unused when computing the model output, they won't be part of the
// autograd graph, and won't receive gradients. These parameters are
// discovered in the `prepare_for_backward` function and their indexes stored
// in the `unused_parameters_` vector.
if (!has_marked_unused_parameters_) {
has_marked_unused_parameters_ = true;
for (const auto& unused_index : unused_parameters_) {
mark_variable_ready(unused_index);
}
}
// Rebuild bucket only if 1) it is the first time to rebuild bucket 2)
// static_graph_ is true or find_unused_parameters_ is false,
// 3) this backward pass needs to run allreduce.
// Here, we just dump tensors and their parameter indices into
// rebuilt_params_ and rebuilt_param_indices_ based on gradient arriving
// order, and then at the end of finalize_backward(), buckets will be
// rebuilt based on rebuilt_params_ and rebuilt_param_indices_, and then
// will be broadcasted and initialized.
// If it is static graph, after 1st iteration, check if a variable
// is ready for communication based on numGradHooksTriggeredMap_.
if (static_graph_after_first_iteration()) {
REDUCER_CHECK(
numGradHooksTriggeredMapPerIteration_[index] > 0,
logger_,
"Your training graph has changed in this iteration, ",
"e.g., one parameter is unused in first iteration, but ",
"then got used in the second iteration. this is not ",
"compatible with static_graph set to True.");
if (--numGradHooksTriggeredMapPerIteration_[index] == 0) {
if (should_rebuild_buckets()) {
push_rebuilt_params(index);
}
// Finally mark variable for which this function was originally called.
mark_variable_ready(index);
}
} else {
if (should_rebuild_buckets()) {
push_rebuilt_params(index);
}
// Finally mark variable for which this function was originally called.
mark_variable_ready(index);
}
}
void Reducer::all_reduce_local_used_map() {
// See Note [Skip allreducing local_used_maps_dev]
// H2D from local_used_maps_ to local_used_maps_dev_
for (const auto i : c10::irange(local_used_maps_.size())) {
if (local_used_maps_dev_[i].is_cuda()) {
// Note [local_used_maps_ -> local_used_maps_dev copying]
// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
// We do async H2D to avoid the blocking overhead. The async copy and
// allreduce respect the current stream, so will be sequenced
// correctly.
//
// Correct sequencing with respect to host operations is also
// essential. The H2D copy_ is stream ordered, while the host's
// changes to local_used_maps_ are host ordered. If a large backlog of
// cuda-stream work pushes the copy_ far into the future, and if no
// blocking calls occur between now and finalize_backward()** such
// that finalize_backward() re-zeroes local_used_maps_ on the host
// before the stream executes the copy_, copy_ will read those zeros
// instead of the values we thought we told it to read here. Copying
// local_used_maps_[i] to a pinned temporary (which the pinned caching
// allocator should supply asynchronously) avoids this nasty, rare
// race condition.
//
// ** In the hoped-for case where all params are used, DDP itself
// won't do any blocking work between now and the re-zeroing, so the
// danger is real.
//
// Defensively ensures local_used_maps_tmp is distinct from
// local_used_maps_[i]
auto local_used_maps_tmp = at::native::empty_like(
local_used_maps_[i],
optTypeMetaToScalarType(local_used_maps_[i].options().dtype_opt()),
local_used_maps_[i].options().layout_opt(),
local_used_maps_[i].options().device_opt(),
true /* pinned_memory */);
// Paranoid asserts here because in some workloads, the pinned
// allocator behaves in a way we don't understand, and may be bugged.
// See https://github.com/pytorch/pytorch/pull/54474
TORCH_INTERNAL_ASSERT(local_used_maps_tmp.is_pinned());
TORCH_INTERNAL_ASSERT(
local_used_maps_tmp.data_ptr() != local_used_maps_[i].data_ptr());
local_used_maps_tmp.copy_(local_used_maps_[i]);
local_used_maps_dev_[i].copy_(local_used_maps_tmp, true);
} else {
local_used_maps_dev_[i].copy_(local_used_maps_[i], true);
}
}
local_used_work_ = process_group_->allreduce(local_used_maps_dev_);
}
void Reducer::checkAndRaiseMarkedTwiceError(size_t index) {
// Something is wrong if all variables contained in this bucket replica have
// already been marked as ready.
// We don't expect the same variable to be marked ready twice.
bool marked_twice =
perIterationReadyParams_.find(index) != perIterationReadyParams_.end();
if (marked_twice) {
// Report index of param that has been marked twice. In debug mode, also
// report fully qualified parameter name.
auto param_name = param_names_.find(index);
const bool found_param_name = param_name != param_names_.end();
TORCH_INTERNAL_ASSERT(
ddp_debug_level_ == c10d::DistributedDebugLevel::OFF ||
found_param_name,
"Expected to find parameter name in debug mode.");
std::string paramInfo = c10::str(
"Parameter at index ",
index,
found_param_name ? c10::str(" with name ", param_name->second) : "",
" has been marked as ready twice. This means that multiple autograd engine ",
" hooks have fired for this particular parameter during this iteration.");
// param_names_ is empty in debug mode.
if (!found_param_name) {
paramInfo += c10::str(
" You can set the environment variable TORCH_DISTRIBUTED_DEBUG to either",
" INFO or DETAIL to print parameter names for further debugging.");
}
std::string common_error = c10::str(
"Expected to mark a variable ready only once. ",
"",
"This error is caused by one of the following reasons: ",
"1) Use of a module parameter outside the `forward` function. ",
"Please make sure model parameters are not shared across multiple ",
"concurrent forward-backward passes. or try to use _set_static_graph() ",
"as a workaround if this module graph does not change ",
"during training loop.",
"2) Reused parameters in multiple reentrant backward passes. For ",
"example, if you use multiple `checkpoint` functions to wrap the ",
"same part of your model, it would result in the same set of ",
"parameters been used by different reentrant backward passes ",
"multiple times, and hence marking a variable ready multiple times. ",
"DDP does not support such use cases in default. You can try to ",
"use _set_static_graph() as a workaround if your module graph ",
"does not change over iterations.");
common_error += c10::str("\n", paramInfo);
REDUCER_CHECK(
has_marked_unused_parameters_,
logger_,
common_error,
"3) Incorrect unused parameter detection. The return value of the ",
"`forward` function is inspected by the distributed data parallel ",
"wrapper to figure out if any of the module's parameters went ",
"unused. For unused parameters, DDP would not expect gradients from ",
"then. However, if an unused parameter becomes part of the autograd ",
"graph at a later point in time (e.g., in a reentrant backward when ",
"using `checkpoint`), the gradient will show up unexpectedly. If all ",
"parameters in the model participate in the backward pass, you can ",
"disable unused parameter detection by passing the keyword argument ",
"`find_unused_parameters=False` to ",
"`torch.nn.parallel.DistributedDataParallel`. If unused parameters ",
"in the model do not change over iterations, You can try to use ",
"_set_static_graph() as a workaround if this module graph does not ",
"change during training loop.");
REDUCER_CHECK(!has_marked_unused_parameters_, logger_, common_error);
}
}
void Reducer::mark_variable_ready(size_t variable_index) {
REDUCER_CHECK(
variable_index < variable_locators_.size(),
logger_,
"Out of range variable index.");
checkAndRaiseMarkedTwiceError(variable_index);
perIterationReadyParams_.insert(variable_index);
backward_stats_[0][variable_index] =
current_time_in_nanos() - backward_compute_start_time_;
// Any time we mark a variable ready (be it in line due to unused parameters,
// or via an autograd hook), we require a call to the finalize function. If
// this doesn't happen before the next iteration (or call to
// `prepare_for_backwards`), we know something is wrong.
require_finalize_ = true;
const auto& bucket_index = variable_locators_[variable_index];
auto& bucket = buckets_[bucket_index.bucket_index];
auto& replica = bucket.replicas[0];
set_divide_factor();
if (bucket.expect_sparse_gradient) {
mark_variable_ready_sparse(variable_index);
} else {
mark_variable_ready_dense(variable_index);
}
// TODO(@pietern): Make this work for both CPU/CUDA tensors.
// When using CPU tensors we don't need to do this.
// // Record event so that we can wait for all of them.
// auto& event = replica.events[bucket_index.intra_bucket_index];
// event.record();
// Check if this was the final gradient for this bucket.
if (--replica.pending == 0) {
// Kick off reduction if all replicas for this bucket are ready.
if (--bucket.pending == 0) {
mark_bucket_ready(bucket_index.bucket_index);
}
}
// Run finalizer function and kick off reduction for local_used_maps once the
// final bucket was marked ready.
if (next_bucket_ == buckets_.size()) {
if (dynamic_graph_find_unused()) {
all_reduce_local_used_map();
}
torch::autograd::Engine::get_default_engine().queue_callback([=] {
std::lock_guard<std::mutex> lock(this->mutex_);
if (should_collect_runtime_stats()) {
record_backward_compute_end_time();
}
// Check that all buckets were completed and had their work kicked off.
TORCH_INTERNAL_ASSERT(next_bucket_ == buckets_.size());
if (static_graph_after_first_iteration() && should_rebuild_buckets()) {
for (const auto& unused_index : unused_parameters_) {
push_rebuilt_params(unused_index);
}
}
this->finalize_backward();
});
}
}
c10::intrusive_ptr<c10::ivalue::Future> Reducer::run_comm_hook(
GradBucket& grad_bucket) {
if (comm_hook_ == nullptr) {
_AllReduceBySumCommHook allreduce_hook(process_group_.get());
return allreduce_hook.runHook(grad_bucket);
} else {
return comm_hook_->runHook(grad_bucket);
}
}
void Reducer::all_reduce_bucket(Bucket& bucket) {
std::vector<at::Tensor> tensors;
tensors.reserve(bucket.replicas.size());
for (const auto& replica : bucket.replicas) {
// TODO(@pietern): Ensure proper synchronization with the CUDA events
// that recorded copies into this contents tensor. If these copies are
// executed on non-default streams, the current stream for the device
// that holds the contents tensor must wait on these events.
//
// As long as autograd uses the default stream for every device,
// these operations are implicitly sequenced, and we don't need to
// do any extra synchronization here.
//
tensors.push_back(replica.contents);
}
auto variables_for_bucket = get_variables_for_bucket(next_bucket_, bucket);
GradBucket grad_bucket(
next_bucket_,
tensors[0],
// Since we only support single-process single-device
// mode, there is always only one replica in the bucket.
bucket.replicas[0].offsets,
bucket.replicas[0].lengths,
bucket.replicas[0].sizes_vec,
variables_for_bucket);
bucket.future_work = run_comm_hook(grad_bucket);
}
std::vector<at::Tensor> Reducer::get_variables_for_bucket(
size_t bucket_index,
const Bucket& bucket) const {
// Check if we have cached mapping previously.
if (has_rebuilt_bucket_ &&
cached_variables_for_bucket_.find(bucket_index) !=
cached_variables_for_bucket_.end()) {
return cached_variables_for_bucket_[bucket_index];
}
std::vector<at::Tensor> variables_for_bucket;
variables_for_bucket.reserve(bucket.variable_indices.size());
for (const auto& variable_index : bucket.variable_indices) {
auto& replica = bucket.replicas[0];
// Grab bucket index where gradient is located using variable_locators_.
auto& bucket_index_for_variable = variable_locators_[variable_index];
// Grab the actual model parameter.
auto& variable =
replica.variables[bucket_index_for_variable.intra_bucket_index];
variables_for_bucket.emplace_back(variable);
}
if (has_rebuilt_bucket_) {
TORCH_INTERNAL_ASSERT_DEBUG_ONLY(
cached_variables_for_bucket_.find(bucket_index) ==
cached_variables_for_bucket_.end());
cached_variables_for_bucket_.insert(
{bucket_index, std::move(variables_for_bucket)});
return cached_variables_for_bucket_[bucket_index];
} else {
return variables_for_bucket;
}
}
// Called when the bucket at the specified index is ready to be reduced.
void Reducer::mark_bucket_ready(size_t bucket_index) {
TORCH_INTERNAL_ASSERT(bucket_index >= next_bucket_);
// Buckets are reduced in sequence. Ignore this bucket if
// it's not its turn to be reduced.
if (bucket_index > next_bucket_) {
return;
}
// Keep going, until we either:
// - have kicked off reduction for all buckets, or
// - found a bucket that's not yet ready for reduction.
for (; next_bucket_ < buckets_.size() && buckets_[next_bucket_].pending == 0;
next_bucket_++) {
num_buckets_ready_++;
if (num_buckets_ready_ == 1 && should_collect_runtime_stats()) {
record_backward_comm_start_time();
}
auto& bucket = buckets_[next_bucket_];
all_reduce_bucket(bucket);
}
}
void Reducer::initialize_buckets(
std::vector<std::vector<size_t>> bucket_indices) {
// If initialize_buckets is called inside DDP constructor, then
// it does not matter rpc context ptr is nullptr or not, as grad
// will not be mutated.
// If initialize_buckets is called during training loop, e.g, inside
// rebuild_buckets(), since grad could be mutated and be pointed to
// bucket_view, then it needs to check rpc context ptr is nullptr or not,
// If rpc context ptr is nullptr, mutate variable.grad(); otherwise,
// mutate grad in rpc context.
#ifndef _WIN32
using torch::distributed::autograd::ThreadLocalDistAutogradContext;
this->rpc_context_.set(ThreadLocalDistAutogradContext::getContextPtr());
#endif
// This shouldn't be called if we're expecting autograd hooks to fire.
REDUCER_CHECK(
!expect_autograd_hooks_,
logger_,
"`initialize_buckets` must NOT be called during autograd execution.");
// Clear current bucket assignment.
buckets_.clear();
variable_locators_.clear();
// Ensure we have a bucket index for every variable.
variable_locators_.resize(replicas_[0].size());
// Iterate over buckets.
const auto bucket_count = bucket_indices.size();
const auto replica_count = replicas_.size();
buckets_.reserve(bucket_count);
for (const auto bucket_index : c10::irange(bucket_count)) {
Bucket bucket;
// TODO(@pietern): Validate indices.
// Must be non-empty, unique, and unique across buckets.
REDUCER_CHECK(
bucket_indices[bucket_index].size() > 0,
logger_,
"Empty bucket specified.");
// Variables that expect sparse gradients must have their own bucket.
if (bucket_indices[bucket_index].size() == 1) {
const auto variable_index = bucket_indices[bucket_index].front();
bucket.expect_sparse_gradient =
expect_sparse_gradients_[0][variable_index];
} else {
for (const auto variable_index : bucket_indices[bucket_index]) {
REDUCER_CHECK(
!expect_sparse_gradients_[0][variable_index],
logger_,
"Buckets with more than one variable cannot include variables ",
"that expect a sparse gradient.");
}
}
// Iterate over model replicas.
BucketReplica replica;
size_t replica_index = 0;
if (bucket.expect_sparse_gradient) {
const auto variable_index = bucket_indices[bucket_index].front();
const auto& variable = replicas_[replica_index][variable_index];
TORCH_INTERNAL_ASSERT(bucket_indices[bucket_index].size() == 1);
replica.variables = {variable};
} else {
at::TensorOptions options;
// The start index of the variable in the flattened tensor.
size_t offset = 0;
// Reserve enough space for the per-variable fields stored in bucket
// replica for efficiency.
const size_t num_variables = bucket_indices[bucket_index].size();
replica.variables.reserve(num_variables);
replica.offsets.reserve(num_variables);
replica.lengths.reserve(num_variables);
replica.sizes_vec.reserve(num_variables);
// Iterate over bucket variables.
for (const auto variable_index : bucket_indices[bucket_index]) {
TORCH_INTERNAL_ASSERT(
variable_index < replicas_[replica_index].size(),
"Out of range variable index specified.");
const auto& variable = replicas_[replica_index][variable_index];
if (!options.has_device()) {
options = options.device(variable.device());
} else {
REDUCER_CHECK(
variable.device() == options.device(),
logger_,
"All parameters in a bucket must be ",
"placed on the same device.");
}
if (!options.has_dtype()) {
options = options.dtype(variable.dtype());
} else {
REDUCER_CHECK(
variable.dtype() == options.dtype(),
logger_,
"All parameters in a bucket must have the same dtype.");
}
const auto length = variable.numel();
replica.variables.push_back(variable);
replica.offsets.push_back(offset);
replica.lengths.push_back(length);
replica.sizes_vec.push_back(variable.sizes());
offset += length;
}
// Allocate bucket contents tensor.
replica.contents = at::empty({static_cast<long>(offset)}, options);
// Note: "Gradient Layout Contract"
//
// Here, create views into the contents tensor for each variable's grad.
// Views serve as entry points to copy_ each grad's data in/out of the
// flat contents tensor.
//
// Gradients may have dense memory but non-row-major-contiguous strides
// (e.g. channels_last or channels_last_3d). For coalesced accesses
// during copy_s, it's beneficial for each view's layout to match its
// grad's layout.
//
// Specifically, we expect torch/csrc/autograd/AccumulateGrad.h produces
// grads that obey there "Gradient Layout Contract":
// (1) if variable.is_non_overlapping_and_dense(), the stashed grad's
// strides match variable.
// (2) else, stashed grad is rowmajor contiguous.
// and create views to match.
//
// If AccumulateGrad breaks the contract, and produces a grad with an
// unexpected layout, performance will degrade due to poor memory access
// patterns when copy_ing grad data in and out of its bucket view.
// However, numerics remain correct, because the bucket view is the same
// on either end of the raw allreduce. bucket_view_in.copy(grad)
// tranposes
// (+ densifies) to the bucket view's layout, the data is allreduced,
// then grad.copy_(bucket_view_out) transposes it back to grad's layout.
//
// The only way the numerics can go haywire is if the bucket views
// themselves have different layouts across processes (or replicas).
// Bucket views' sizes and strides are set based on param layouts, using
// the same logic that (we expect) AccumulateGrad uses for their grads.
// Therefore, the only way a bucket view could have different layouts in
// different processes is if its param has a different layout in
// different processes. We can check that param layouts match across
// processes and replicas in Reducer's constructor by allreducing some
// metadata. Checking just once won't catch if someone messes with
// param layouts over time, but not messing with params after DDP
// construction is already a documented constraint.
initialize_bucket_views(replica, replica.contents);
}
// Add bucket replica to enclosing bucket.
bucket.replicas.push_back(std::move(replica));
// Map participating variables to this bucket.
// This is identical across replicas so we only need to do this once.
size_t intra_bucket_index = 0;
for (const auto variable_index : bucket_indices[bucket_index]) {
TORCH_INTERNAL_ASSERT(
variable_index < variable_locators_.size(),
"Out of range variable index specified.");
variable_locators_[variable_index] =
VariableLocator(bucket_index, intra_bucket_index++);
}
bucket.variable_indices = std::move(bucket_indices[bucket_index]);
buckets_.push_back(std::move(bucket));
}
}
// (see Note: "Gradient Layout Contract" in initialize_buckets).
void Reducer::initialize_bucket_views(
Reducer::BucketReplica& replica,
at::Tensor& contents) {
for (const auto i : c10::irange(replica.variables.size())) {
auto& v = replica.variables[i];
const auto offset = replica.offsets[i];
const auto length = replica.lengths[i];
if (v.is_non_overlapping_and_dense()) {
// If the param's memory is dense, match its layout, anticipating
// the autograd engine (AccumulateGrad) will also create gradients
// matching its layout.
replica.bucket_views_in.push_back(
contents.as_strided(v.sizes(), v.strides(), offset));
} else {
// Fall back to a C-style contiguous view, again anticipating
// AccumulateGrad will do the same when stashing grads for non-dense
// params.
replica.bucket_views_in.push_back(
contents.narrow(0, offset, length).view(v.sizes()));
}
// By default `bucket_views_out` and `bucket_views_in` are
// essentially the same thing.
replica.bucket_views_out = replica.bucket_views_in;
// If gradient_as_bucket_view_ is set as true, then there are two cases to
// handle: initialize_bucket_views could be called inside initialize_buckets
// when rebuild_buckets, if grad has already been defined/calculated in
// previous iteration, old grad needs to be copied into new bucket_view and
// let grad point to the new bucket_view, initialize_bucket_views could also
// be called inside initialize_buckets during construction. Grads are not
// defined during construction time, in this case, do not let grad point to
// bucket_view, because grads should be kept as being undefined for globally
// unused parameters.
if (gradient_as_bucket_view_) {
auto& bucket_view = replica.bucket_views_in.back();
runGradCallbackForVariable(v, [&](auto& grad) {
if (grad.defined() && !grad.is_alias_of(bucket_view)) {
bucket_view.copy_(grad);
grad = bucket_view;
// The grad is modefied and needs to be written back.
return true;
}
// The grad is not modified and does not need to be written back.
return false;
});
}
}
}
// (see Note: "Gradient Layout Contract" in initialize_buckets).
void Reducer::populate_bucket_views_out(
Reducer::BucketReplica& replica,
at::Tensor& tensor) {
replica.bucket_views_out.clear();
for (const auto i : c10::irange(replica.variables.size())) {
const auto& v = replica.variables[i];
const auto offset = replica.offsets[i];
const auto length = replica.lengths[i];
if (v.is_non_overlapping_and_dense()) {
// If the param's memory is dense, match its layout, anticipating
// the autograd engine (AccumulateGrad) will also create gradients
// matching its layout.
replica.bucket_views_out.push_back(
tensor.as_strided(v.sizes(), v.strides(), offset));
} else {
// Fall back to a C-style contiguous view, again anticipating
// AccumulateGrad will do the same when stashing grads for non-dense
// params.
replica.bucket_views_out.push_back(
tensor.narrow(0, offset, length).view(v.sizes()));
}
}
}
void Reducer::prepare_for_forward() {
std::lock_guard<std::mutex> lock(mutex_);
num_iterations_++;
if (should_collect_runtime_stats()) {
record_forward_compute_start_time();
}
}
void Reducer::reset_bucket_counting() {
next_bucket_ = 0;
// Reset num_buckets_ready_ at the beginning of backward computation
// in each iteration.
num_buckets_ready_ = 0;
for (auto& bucket : buckets_) {
for (auto& replica : bucket.replicas) {
replica.pending = replica.variables.size();
}
bucket.pending = bucket.replicas.size();
}
if (static_graph_) {
numGradHooksTriggeredMapPerIteration_ = numGradHooksTriggeredMap_;
}
}
// Traverse the autograd graph starting at the specified output.
// All parameters for which we have a pointer to their gradient accumulation
// functions, but don't show up in the autograd graph will be marked ready for
// for reduction as soon as the first autograd hook is called. This is not
// done immediately because the model output may be ignored, and we only
// want to start performing reductions on `torch.autograd.backward()`.
void Reducer::search_unused_parameters(
const std::vector<torch::autograd::Variable>& outputs) {
std::unordered_set<torch::autograd::Node*> seen;
std::vector<torch::autograd::Node*> queue;
RECORD_FUNCTION(
"torch.distributed.ddp.reducer::search_unused_parameters",
std::vector<c10::IValue>());
// Seed queue with the grad functions of all outputs.
for (const auto& output : outputs) {
const auto& grad_fn = output.grad_fn();
if (grad_fn) {
queue.push_back(grad_fn.get());
}
}
// Traverse the autograd graph starting at the specified output.
while (!queue.empty()) {
auto fn = queue.back();
queue.pop_back();
for (const auto& edge : fn->next_edges()) {
if (auto next_ptr = edge.function.get()) {
const bool was_inserted = seen.insert(next_ptr).second;
if (was_inserted) {
queue.push_back(next_ptr);
}
}
}
}
// Find accumulator functions that don't show up in this graph.
for (const auto& it : gradAccToVariableMap_) {
// If the accumulator function is present in the graph, we know
// a gradient will be computed for the corresponding parameter.
if (seen.count(it.first) == 0) {
unused_parameters_.push_back(it.second);
}
}
// Warn user about unnecessary perf hit if all parameters were used in
// forward.
if (unused_parameters_.empty()) {
TORCH_WARN_ONCE(
"find_unused_parameters=True was specified in DDP constructor, "
"but did not find any unused parameters in the forward pass. This flag "
"results in an extra traversal of the autograd graph every iteration, "
" which can adversely affect performance. If your model indeed never "
"has any unused parameters in the forward pass, consider turning this "
"flag off. Note that this warning may be a false positive if your model "
"has flow control causing later iterations to have unused parameters.");
}
}
void Reducer::prepare_for_backward(
const std::vector<torch::autograd::Variable>& outputs) {
std::lock_guard<std::mutex> lock(mutex_);
backward_compute_start_time_ = current_time_in_nanos();
if (should_collect_runtime_stats()) {
record_backward_compute_start_time();
}
// Reset accounting.
expect_autograd_hooks_ = true;
reset_bucket_counting();
// Reset unused parameter accounting.
has_marked_unused_parameters_ = false;
// Reset per iteration marked ready parameters.
perIterationReadyParams_.clear();
// If static graph is not set, search graph to detect unused parameters.
// When static graph is set, unused_parameters_ will be detected and will
// not change after 1st iteration.
// If static_graph_ = false and find_unused_parameters_ is false,
// we assume that autograd hooks for ALL variables will be called,
// and we don't have to search the autograd graph for presence of these hooks.
if (dynamic_graph_find_unused()) {
unused_parameters_.clear();
search_unused_parameters(outputs);
}
}
void Reducer::copy_bucket_to_grad(
at::Tensor& variable,
Reducer::BucketReplica& replica,
size_t intra_bucket_index,
bool global_unused) {
const auto& bucket_view = replica.bucket_views_out[intra_bucket_index];
runGradCallbackForVariable(variable, [&](auto& grad) {
// If a parameter is globally unused, we keep its grad untouched.
if (!global_unused) {
if (!grad.defined()) {
// Creates grad according to the "Gradient Layout Contract"
// (see torch/csrc/grad/AccumulateGrad.h)
grad =
torch::autograd::utils::clone_obey_contract(bucket_view, variable);
} else {
grad.copy_(bucket_view);
}
// The grad is modified and needs to be written back.
return true;
}
// The grad is not modified.
return false;
});
}
std::vector<std::string> Reducer::getUnmarkedParamsForIteration() {
std::vector<std::string> unMarkedParamNames;
for (const auto& it : param_names_) {
if (perIterationReadyParams_.find(it.first) ==
perIterationReadyParams_.end()) {
unMarkedParamNames.push_back(it.second);
}
}
return unMarkedParamNames;
}
std::vector<size_t> Reducer::getUnmarkedParamIndicesForIteration() {
std::vector<size_t> unmarked_param_indices;
const auto variable_count = replicas_[0].size();
for (const auto variable_index : c10::irange(variable_count)) {
if (perIterationReadyParams_.find(variable_index) ==
perIterationReadyParams_.end()) {
unmarked_param_indices.push_back(variable_index);
}
}
return unmarked_param_indices;
}
// A bucket with one or more dense tensors needs to be unflattened.
void Reducer::finalize_bucket_dense(Bucket& bucket) {
size_t replica_index = 0;
auto& replica = bucket.replicas[replica_index];
for (const auto intra_bucket_index : c10::irange(replica.variables.size())) {
auto& variable = replica.variables[intra_bucket_index];
const auto offset = replica.offsets[intra_bucket_index];
const auto length = replica.lengths[intra_bucket_index];
bool global_unused = false;
// See Note [Skip allreducing local_used_maps_dev]
if (static_graph_ || find_unused_parameters_) {
// Determine if this param has been used globally or not.
//
// If the variable was used locally, it is also used globally and then
// we don't need to wait for the reduction. Otherwise we lazily wait for
// the reduction to complete, only when we see a variable that was
// unused locally. Then we end up delaying the synchronization point
// that local_used_work_->wait() implies. If we don't have any unused
// parameters at all, we can skip waiting for the work to complete
// altogether, and cause negligible performance overhead for models
// where all parameters are used. Such lazily waiting means minimizing
// performance impact for the big majority of models where all
// parameters are always used. Then we only pay the overhead cost if
// there is indeed a parameter that is locally unused, because we need
// to check if it's also globally unused.
size_t variable_index = bucket.variable_indices[intra_bucket_index];
// Note: global_unused might not be global yet. As we lazily wait for
// the reduction to complete, it becomes really global only if we get to
// the point as below where we wait for the reduction work, make D2H
// copy, and update global_unused with the real global consensus, i.e.
// local_used_maps_reduced_ is true.
global_unused =
local_used_maps_[replica_index][variable_index].item<int>() == 0;
if (global_unused && !local_used_maps_reduced_) {
// Wait for local_used_maps reduction to complete.
local_used_work_->wait();
// D2H from local_used_maps_dev_ to local_used_maps_
for (const auto i : c10::irange(local_used_maps_.size())) {
// Blocking copy, if local_used_maps_dev_ is cuda
local_used_maps_[i].copy_(local_used_maps_dev_[i]);
}
global_unused =
local_used_maps_[replica_index][variable_index].item<int>() == 0;
local_used_maps_reduced_ = true;
}
}
if (!gradient_as_bucket_view_) {
copy_bucket_to_grad(variable, replica, intra_bucket_index, global_unused);
} else {
const auto& bucket_view_out =
replica.bucket_views_out[intra_bucket_index];
auto& bucket_view_in = replica.bucket_views_in[intra_bucket_index];
// If communication_hook is registered, bucket_view_out stores
// allreduced results in a newly allocated tensor, copy bucket_view_out
// back to bucket_view_in that referring to replica.content tensor and
// grad.
if (!bucket_view_in.is_alias_of(bucket_view_out)) {
bucket_view_in.copy_(bucket_view_out);
}
runGradCallbackForVariable(variable, [&](auto& grad) {
// If a parameter is globally unused, we keep its grad untouched.
if (!global_unused) {
// If grad is globally used but locally unused, let grad point to
// bucket_view_in
if (!grad.defined()) {
grad = bucket_view_in;
} else {
if (!grad.is_alias_of(bucket_view_in)) {
REDUCER_CHECK(
false,
logger_,
"Detected at least one parameter gradient is not the "
"expected DDP bucket view with gradient_as_bucket_view=True. "
"This may happen (for example) if multiple allreduce hooks "
"were registered onto the same parameter. If you hit this error, "
"please file an issue with a minimal repro.");
}
}
// The grad is modified and needs to be written back.
return true;
}
// The grad is not modified.
return false;
});
}
}
}
void Reducer::save_thread_local_state() {
std::lock_guard<std::mutex> guard(mutex_);
// Don't preserve grad_mode across thread boundaries, as we will be passing
// from forward pass to autograd engine hooks, and autograd engine takes care
// of grad mode.
thread_local_state_ = at::ThreadLocalState(/* keep_grad_mode */ false);
}
void Reducer::finalize_backward() {
// No longer expect autograd hooks to fire after this function returns.
TORCH_INTERNAL_ASSERT(expect_autograd_hooks_);
expect_autograd_hooks_ = false;
// No longer require call to finalize after this function returns.
TORCH_INTERNAL_ASSERT(require_finalize_);
require_finalize_ = false;
// Wait for asynchronous reduction to complete and unflatten contents.
for (auto& bucket : buckets_) {
// See Note [DDP Communication Hook]
TORCH_INTERNAL_ASSERT(
bucket.future_work,
"Expected bucket.future_work not to be null. "
"This may indicate that communication hook was not properly installed.");
bucket.future_work->wait();
auto future_result = comm_hook_ == nullptr
? detail::parseCppCommHookResult(bucket.future_work->value())
: comm_hook_->parseHookResult(bucket.future_work->value());
for (const auto i : c10::irange(future_result.size())) {
auto& replica = bucket.replicas[i];
if (bucket.expect_sparse_gradient) {
replica.contents.copy_(future_result[i]);
} else {
// Reinitialize only `bucket_views_out` with the future_result by
// following the same logic in `initialize_buckets`.
populate_bucket_views_out(replica, future_result[i]);
}
}
// Unset allreduce division factor, as it may change in next backwards pass
// when running with DDP join mode.
div_factor_ = kUnsetDivFactor;
if (!bucket.expect_sparse_gradient) {
// We don't need to finalize the sparse bucket since the sparse grad and
// the bucket essentially point to the same storage. As a result, once
// the allreduce is done, the sparse grads are automatically updated.
finalize_bucket_dense(bucket);
}
}
// See Note [Skip allreducing local_used_maps_dev]
if (dynamic_graph_find_unused() || static_graph_first_iteration()) {
// Due to the lazy wait, it is possible that reduction of the current
// iteration is still going when the one for next iteration gets kicked off.
// For such case, we want to wait explicitly to make sure the reduction does
// complete before kicking off next one. Otherwise the previous one may
// interfere, write to the device-side memory and clobber the content of
// local_unused_maps_dev_.
if (!local_used_maps_reduced_) {
local_used_work_->wait();
}
}
if (dynamic_graph_find_unused()) {
// Reset unused parameter accounting.
// See Note [local_used_maps_ -> local_used_maps_dev copying]
for (auto& local_used : local_used_maps_) {
local_used.fill_(0);
}
local_used_maps_reduced_ = false;
}
if (should_collect_runtime_stats()) {
record_backward_comm_end_time();
}
}
void Reducer::runGradCallbackForVariable(
at::Tensor& variable,
GradCallback&& cb) {
#ifdef _WIN32
cb(variable.mutable_grad());
#else
auto context_ptr = rpc_context_.context_ptr.load();
if (context_ptr == nullptr) {
cb(variable.mutable_grad());
} else {
// Under distributed autograd
context_ptr->runGradCallbackForVariable(variable, std::move(cb));
}
#endif
}
#ifndef _WIN32
void Reducer::RpcContext::set(ContextPtr&& new_context_ptr) {
// We should set 'new_context_ptr' even if it's nullptr. That means the
// reducer is under a local backward run.
const auto new_context_raw_ptr = new_context_ptr.get();
if (context_ptr.exchange(new_context_raw_ptr) != new_context_raw_ptr) {
// Set the shared ptr to the context only if it's set first time.
// All call sites should use the same context ptr.
// Use an atomic to avoid data race from multiple threads.
context_ptr_holder = std::move(new_context_ptr);
}
}
#endif
void Reducer::sync_bucket_indices(
std::vector<std::vector<size_t>>& bucket_indices) {
auto num_buckets = bucket_indices.size();
std::vector<size_t> bucket_sizes;
bucket_sizes.reserve(num_buckets);
int64_t total_size = 0;
for (const auto i : c10::irange(num_buckets)) {
auto bucket_size = bucket_indices.at(i).size();
bucket_sizes.push_back(bucket_size);
total_size += bucket_size;
}
at::TensorOptions options;
options = options.dtype(at::kInt);
options = options.device(replicas_[0][0].device());
// Group indices and num_bucket together into indices_tensor
// Broadcast this tensor first, as its size is equal among all processes
auto indices_tensor = at::empty({total_size + 1}, at::kInt);
auto indices_accessor = indices_tensor.accessor<int, 1>();
auto indices_accessor_Index = 0;
for (const auto i : c10::irange(num_buckets)) {
const auto& bucket_size = bucket_indices.at(i).size();
for (const auto j : c10::irange(bucket_size)) {
indices_accessor[indices_accessor_Index++] = bucket_indices[i][j];
}
}
indices_accessor[indices_accessor_Index] = num_buckets;
// Copy CPU tensor to device tensor, as the process_group_ could be NCCL and
// it can only broadcast device tensors.
auto indices_tensor_device = at::empty({total_size + 1}, options);
indices_tensor_device.copy_(indices_tensor, /*non_blocking=*/true);
std::vector<at::Tensor> indices_tensor_list = {indices_tensor_device};
process_group_->broadcast(indices_tensor_list)->wait();
indices_tensor.copy_(indices_tensor_list.front(), /*non_blocking=*/false);
// Update num_buckets after receiving it from rank 0
num_buckets = indices_accessor[indices_accessor_Index];
// Broadcast bucket_sizes
auto bucket_sizes_tensor = at::empty({(int64_t)num_buckets}, at::kInt);
auto bucket_sizes_accessor = bucket_sizes_tensor.accessor<int, 1>();
for (const auto i : c10::irange(num_buckets)) {
// For rank != 0, it is possible that local num buckets bucket_sizes.size()
// is smaller than broadcasted num_buckets
bucket_sizes_accessor[i] =
bucket_sizes.at(std::min(i, (bucket_sizes.size() - 1)));
}
auto bucket_sizes_tensor_device = at::empty({(int64_t)num_buckets}, options);
bucket_sizes_tensor_device.copy_(bucket_sizes_tensor, /*non_blocking=*/true);
std::vector<at::Tensor> bucket_sizes_tensor_list = {
bucket_sizes_tensor_device};
process_group_->broadcast(bucket_sizes_tensor_list)->wait();
bucket_sizes_tensor.copy_(
bucket_sizes_tensor_list.front(), /*non_blocking=*/false);
// Clear bucket_indices first, and then update bucket_indices using received
// num_buckets, bucket_sizes_tensor and indices_tensor from rank 0
bucket_indices.clear();
bucket_indices.reserve(num_buckets);
indices_accessor_Index = 0;
for (const auto i : c10::irange(num_buckets)) {
const auto& bucket_size = bucket_sizes_accessor[i];
std::vector<size_t> bucket;
bucket.reserve(bucket_size);
for (const auto j : c10::irange(bucket_size)) {
bucket.push_back(indices_accessor[indices_accessor_Index++]);
}
bucket_indices.emplace_back(std::move(bucket));
}
}
bool Reducer::rebuild_buckets() {
// Ensure reduction for previous backwards pass is finished. If user's model
// has unused parameters for example, this will raise an error recommending to
// run with find_unused_parameters=True, instead of the size mismatch
// exception below.
std::lock_guard<std::mutex> lock(mutex_);
ensure_prior_reduction_finished();
if (!should_rebuild_buckets() || rebuilt_params_.empty()) {
return false;
}
TORCH_INTERNAL_ASSERT(
rebuilt_params_.size() == rebuilt_param_indices_.size(),
c10::str(
"rebuilt parameter tensors size is not same as rebuilt parameter indices size: ",
rebuilt_params_.size(),
" versus ",
rebuilt_param_indices_.size()));
TORCH_INTERNAL_ASSERT(
replicas_[0].size() == rebuilt_param_indices_.size(),
c10::str(
"rebuilt parameter indices size is not same as original model parameters size.",
"Original model param size is: ",
replicas_[0].size(),
" versus rebuilt params size of: ",
rebuilt_param_indices_.size()));
std::vector<std::vector<size_t>> rebuilt_bucket_indices;
std::vector<size_t> bucket_size_limits;
bucket_size_limits.push_back(kDefaultFirstBucketBytes);
bucket_size_limits.push_back(bucket_bytes_cap_);
rebuilt_bucket_indices = compute_bucket_assignment_by_size(
rebuilt_params_,
bucket_size_limits,
expect_sparse_gradients_[0],
rebuilt_param_indices_);
// For rebuilt bucket indices, it needs to be synced across all ranks.
// Broadcast the newly rebuilt bucket indices from rank 0 in default.
// After syncing up rebuilt bucket indices, initialize buckets for reducer.
sync_bucket_indices(rebuilt_bucket_indices);
has_rebuilt_bucket_ = true;
rebuilt_params_.clear();
rebuilt_param_indices_.clear();
initialize_buckets(std::move(rebuilt_bucket_indices));
return true;
}
// See Note [DDP Communication Hook]
void Reducer::register_comm_hook(std::unique_ptr<CommHookInterface> iface) {
REDUCER_CHECK(
comm_hook_ == nullptr,
logger_,
"register_comm_hook or register_builtin_comm_hook can only be called once.");
comm_hook_ = std::move(iface);
}
// See Note [DDP Communication Hook]
void Reducer::register_builtin_comm_hook(
c10d::BuiltinCommHookType comm_hook_type) {
REDUCER_CHECK(
comm_hook_ == nullptr,
logger_,
"register_builtin_comm_hook or register_comm_hook can only be called once.");
switch (comm_hook_type) {
case c10d::BuiltinCommHookType::ALLREDUCE:
comm_hook_ =
std::make_unique<c10d::AllReduceCommHook>(process_group_.get());
LOG(INFO) << "Built-in communication hook ALLREDUCE is registered.";
break;
case c10d::BuiltinCommHookType::FP16_COMPRESS:
comm_hook_ =
std::make_unique<c10d::FP16CompressCommHook>(process_group_.get());
LOG(INFO) << "Built-in communication hook FP16_COMPRESS is registered.";
break;
default:
TORCH_WARN_ONCE(
"Unknown built-in DDP comm hook type is provided. No comm hook will be used.");
}
}
void Reducer::ensure_prior_reduction_finished() {
// Check that any prior reduction has finished.
// The variable `require_finalize_` is true until all gradients
// have been computed and reduction of all buckets has been kicked off.
if (require_finalize_) {
REDUCER_CHECK(
!static_graph_,
logger_,
"Expected to have finished reduction in the prior iteration before "
"starting a new one. "
"This error indicates that your training graph has changed ",
"in this iteration, e.g., one parameter is used in first ",
"iteration, but then got unused in the second iteration. ",
"this is not compatible with static_graph set to True.");
// Collect unmarked parameter indices, additionally, in debug mode retrieve
// parameter names.
auto unmarked_param_indices = getUnmarkedParamIndicesForIteration();
// We should have some unmarked parameter indices, otherwise we would not
// have run into this error branch.
TORCH_INTERNAL_ASSERT(unmarked_param_indices.size() > 0);
const std::string unmarkedParamIndices =
c10::Join(", ", unmarked_param_indices);
std::string kBaseErrorMsg =
"Expected to have finished reduction in the prior iteration before "
"starting a new one. "
""
"This error indicates that your module has parameters that were "
"not used in producing loss. ";
std::string kOutputsNotUsedInLossErrorMsg =
"making sure all "
"`forward` function outputs participate in calculating loss. ";
std::string kDDPBugErrorMsg =
"\nIf you already have done the above, then the distributed "
"data parallel module wasn't able to locate the output tensors in the "
"return value of your module's `forward` function. "
"Please include the loss function and the structure of the return "
"value of `forward` of your module when reporting this issue (e.g. "
"list, dict, iterable).";
if (!find_unused_parameters_) {
// Parameters may have been unused in forward pass, or not all outputs
// were used in producing loss.
kBaseErrorMsg +=
"You can enable unused parameter detection by passing the "
"keyword argument `find_unused_parameters=True` to "
"`torch.nn.parallel.DistributedDataParallel`, and by \n";
kBaseErrorMsg += kOutputsNotUsedInLossErrorMsg;
kBaseErrorMsg += kDDPBugErrorMsg;
} else {
// Note that it does not really matter whether unused_parameters_.empty(),
// since user may have enabled detection but this particular iteration
// could have used or not used all parameters.
kBaseErrorMsg +=
"Since `find_unused_parameters=True` is enabled, this likely "
" means that not all `forward` outputs participate in computing loss. You can fix this by ";
kBaseErrorMsg += kOutputsNotUsedInLossErrorMsg;
kBaseErrorMsg += kDDPBugErrorMsg;
}
const std::string unmarked_param_indices_info = c10::str(
"\n",
"Parameter indices which did not receive grad for rank ",
process_group_->getRank(),
": ",
unmarked_param_indices);
if (ddp_debug_level_ == DistributedDebugLevel::OFF) {
// Without debug mode, log unmarked_param_indices, as well as
// recommendation to use debug mode to print parameter names.
kBaseErrorMsg += unmarked_param_indices_info;
kBaseErrorMsg +=
"\n In addition, you can set the environment variable "
"TORCH_DISTRIBUTED_DEBUG to either INFO or DETAIL to print out information "
"about which particular parameters did not receive gradient on this rank "
"as part of this error";
} else {
// Retrieve set of parameter names that did not receive gradient.
auto unmarkedParams = getUnmarkedParamsForIteration();
TORCH_INTERNAL_ASSERT(unmarkedParams.size() > 0);
for (const auto& s : unmarkedParams) {
LOG(INFO) << "[Rank " << process_group_->getRank() << "] "
<< "Parameter: " << s
<< " did not get gradient in backwards pass.";
}
const std::string unmarkedParamInfo = c10::Join(", ", unmarkedParams);
// In debug mode, log param names and indices that went unused.
kBaseErrorMsg += c10::str(
"\n",
"Parameters which did not receive grad for rank ",
process_group_->getRank(),
": ",
unmarkedParamInfo);
kBaseErrorMsg += unmarked_param_indices_info;
}
REDUCER_CHECK(false, logger_, kBaseErrorMsg);
}
}
void Reducer::set_ddp_runtime_logging_sample_rate(int sample_rate) {
ddp_runtime_logging_sample_rate_ = sample_rate;
}
int Reducer::get_ddp_runtime_logging_sample_rate() {
return ddp_runtime_logging_sample_rate_;
}
bool Reducer::should_collect_runtime_stats() {
if (num_iterations_ > 0 &&
(num_iterations_ <= 10 ||
num_iterations_ % get_ddp_runtime_logging_sample_rate() == 0)) {
return true;
}
return false;
}
void Reducer::record_forward_compute_start_time() {
if (timer_) {
timer_->record(Timer::Event::kForwardStart);
}
}
void Reducer::record_backward_compute_start_time() {
if (timer_) {
timer_->record(Timer::Event::kBackwardComputeStart);
}
}
void Reducer::record_backward_compute_end_time() {
if (timer_) {
timer_->record(Timer::Event::kBackwardComputeEnd);
}
}
void Reducer::record_backward_comm_start_time() {
if (timer_) {
timer_->record(Timer::Event::kBackwardCommStart);
}
}
void Reducer::record_backward_comm_end_time() {
if (timer_) {
timer_->record(Timer::Event::kBackwardCommEnd);
}
}
void Reducer::set_static_graph() {
std::lock_guard<std::mutex> lock(mutex_);
REDUCER_CHECK(
num_iterations_ == 0,
logger_,
"set_static_graph() should be called before training loop starts "
"and after DistributedDataParallel is constructed.");
static_graph_ = true;
// when static_graph_ is set as true, always initialize_local_used_map
// and detect the global unused parameters in the first iteration.
initialize_local_used_map();
}
namespace {
// Tensors may be coalesced into buckets. Buckets must contain tensors of
// the same type, on the same device, so a bucket can identified by a
// composite key of a tensor's type identifier and its device.
struct BucketKey {
BucketKey(c10::ScalarType type, c10::Device device)
: type(std::move(type)), device(std::move(device)) {}
const c10::ScalarType type;
const c10::Device device;
// See torch/csrc/utils/hash.h for dispatch code.
static size_t hash(const BucketKey& key) {
return c10::get_hash(key.type, key.device);
}
};
inline bool operator==(const BucketKey& lhs, const BucketKey& rhs) {
return lhs.type == rhs.type && lhs.device == rhs.device;
}
} // namespace
std::vector<std::vector<size_t>> compute_bucket_assignment_by_size(
const std::vector<at::Tensor>& tensors,
const std::vector<size_t>& bucket_size_limits,
const std::vector<bool>& expect_sparse_gradient,
const std::vector<int64_t>& tensor_indices) {
// Either expect_sparse_gradient is not specified or it has as many elements
// as the vector with tensors.
TORCH_INTERNAL_ASSERT(
expect_sparse_gradient.empty() ||
(tensors.size() == expect_sparse_gradient.size()));
TORCH_INTERNAL_ASSERT(tensors.size() > 0);
std::vector<std::vector<size_t>> result;
result.reserve(tensors.size());
// Keep iterator into the size_limit vector by tensor type and device.
// This is done so that we can use the consecutive bucket limits per type.
std::unordered_map<
BucketKey,
std::vector<size_t>::const_iterator,
c10::hash<BucketKey>>
bucket_size_limit_iterators;
// Local accumulator type for a single bucket.
struct BucketAccumulator {
std::vector<size_t> indices;
size_t size = 0;
};
// Keep vector of indices and size accumulator by tensor type and device.
std::unordered_map<BucketKey, BucketAccumulator, c10::hash<BucketKey>>
buckets;
for (const auto i : c10::irange(tensors.size())) {
const auto& tensor = tensors[i];
// TODO: This is not a reducer method so it does not have access to logger,
// pass in logger directly here.
TORCH_CHECK(!tensor.is_sparse(), "No support for sparse tensors.");
// when tensor_indices is empty, the index of tensors[i] assigned to
// bucket is i, otherwise the tensor index is tensor_indices[i].
auto tensor_index = i;
if (!tensor_indices.empty()) {
tensor_index = tensor_indices[i];
}
// If we expect a sparse gradient to be produced for this tensor, it cannot
// be grouped together with other gradients and gets its own bucket.
if (!expect_sparse_gradient.empty() &&
expect_sparse_gradient[tensor_index]) {
result.push_back({tensor_index});
continue;
}
auto key = BucketKey(tensor.scalar_type(), tensor.device());
auto& bucket = buckets[key];
bucket.indices.push_back(tensor_index);
bucket.size += tensor.numel() * tensor.element_size();
// Initialize bucket size limit iterator if necessary.
if (bucket_size_limit_iterators.count(key) == 0) {
bucket_size_limit_iterators[key] = bucket_size_limits.begin();
}
auto& bucket_size_limit_iterator = bucket_size_limit_iterators[key];
const auto bucket_size_limit = *bucket_size_limit_iterator;
if (bucket.size >= bucket_size_limit) {
result.emplace_back(std::move(bucket.indices));
bucket = BucketAccumulator();
// Advance to the next bucket size limit for this type/device.
auto next = bucket_size_limit_iterator + 1;
if (next != bucket_size_limits.end()) {
bucket_size_limit_iterator = next;
}
}
}
// Add remaining buckets.
for (auto& it : buckets) {
auto& bucket = it.second;
if (!bucket.indices.empty()) {
result.emplace_back(std::move(bucket.indices));
}
}
// If tensor_indices is not empty, the order of the tensors is in the gradient
// ready order, so no need to sort.
// If tensor_indices is empty, sort resulting buckets by the minimum tensor
// index they include. We assume that the order of the tensors is the order in
// which they are used (or the reverse order in which their gradients are
// produced). This sorting step ensures that the buckets are ready in
// consecutive order.
if (tensor_indices.empty()) {
std::sort(
result.begin(),
result.end(),
[](const std::vector<size_t>& a, const std::vector<size_t>& b) {
const auto amin = std::min_element(a.begin(), a.end());
const auto bmin = std::min_element(b.begin(), b.end());
return *amin < *bmin;
});
}
return result;
}
// Verifies corresponding params in replica 0 have the same sizes/strides
// across processes.
void verify_replica0_across_processes(
c10::intrusive_ptr<c10d::ProcessGroup> process_group,
std::vector<std::vector<at::Tensor>> model_replicas) {
size_t i = 0;
for (const auto& t : model_replicas[0]) {
i += 2 * t.dim();
}
at::TensorOptions options;
options = options.dtype(at::kLong);
auto metadata = at::empty({static_cast<long>(i)}, options);
// Technically, process 0 is the broadcast source, so only process 0 needs
// to populate metadata. But no harm keeping work aligned across processes.
auto metadata_accessor = metadata.accessor<int64_t, 1>();
i = 0;
for (const auto& t : model_replicas[0]) {
for (const auto& sz : t.sizes()) {
metadata_accessor[i++] = sz;
}
for (const auto& str : t.strides()) {
metadata_accessor[i++] = str;
}
}
auto metadata_dev = metadata.clone().to(model_replicas[0][0].device());
std::vector<at::Tensor> vec{metadata_dev};
process_group->broadcast(vec)->wait();
// Technically, process 0 doesn't need to double-check metadata, because it
// was the source. But no harm keeping work aligned.
auto control = at::empty({static_cast<long>(i)}, options);
control.copy_(metadata_dev, /*non_blocking=*/false);
auto control_accessor = control.accessor<int64_t, 1>();
i = 0;
for (const auto p : c10::irange(model_replicas[0].size())) {
const auto& t = model_replicas[0][p];
// I'd like to include which process we are in the message,
// but ProcessGroup::getRank is not public!
for (const auto& sz : t.sizes()) {
// TODO: pass in logger and use REDUCER_CHECK.
TORCH_CHECK(
sz == control_accessor[i++],
"replicas[0][",
p,
"] in this process"
" with sizes ",
t.sizes(),
" appears not to match sizes of the same param in process 0.");
}
for (const auto& str : t.strides()) {
// TODO: pass in logger and use REDUCER_CHECK.
TORCH_CHECK(
str == control_accessor[i++],
"replicas[0][",
p,
"] in this process"
" with strides ",
t.strides(),
" appears not to match strides of the same param in process 0.");
}
}
}
} // namespace c10d