commit 2ea4c37c1ecf05a8495211d55ed6888439b1b9cf
author Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Wed Nov 20 02:16:02 2019 -0800
committer GitHub <noreply@github.com> Wed Nov 20 02:16:02 2019 -0800
tree 68df5ec2180ca4592ddcb7e1a310392512f638d6
parent 132243957ce834cf5ffced4bf8e39d00f6e34e5f

bpo-38823: Fix refleak in marshal init error path (GH-17260)

(cherry picked from commit 33b671e72450bf4b5a946ce0dde6b7fe21150108)

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

Python/marshal.c

diff --git a/Python/marshal.c b/Python/marshal.c
index b2daff2c..c6a06e8 100644
--- a/Python/marshal.c
+++ b/Python/marshal.c
@@ -1829,6 +1829,9 @@
     PyObject *mod = PyModule_Create(&marshalmodule);
     if (mod == NULL)
         return NULL;
-    PyModule_AddIntConstant(mod, "version", Py_MARSHAL_VERSION);
+    if (PyModule_AddIntConstant(mod, "version", Py_MARSHAL_VERSION) < 0) {
+        Py_DECREF(mod);
+        return NULL;
+    }
     return mod;
 }