| commit | 3eaf141255889a18946773bf506874d60ace0a06 | [log] [tgz] |
|---|---|---|
| author | Armando Montanez <amontanez@google.com> | Tue Dec 21 15:13:53 2021 -0800 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Dec 22 00:21:18 2021 +0000 |
| tree | d1402439b7132b388e859eddd9eafe3babe1ef8b | |
| parent | e0bbfa7070d6e75bb3d6bc9df3a5ded8c740b16e [diff] |
pw_transfer: Do not Finish() inactive transfer Prevents calling Finish() on an inactive transfer as doing so will cause a crash. Change-Id: Idc97ba91603c22683e296d5da8ebd43c6cd31e81 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/75980 Reviewed-by: Alexei Frolov <frolv@google.com> Commit-Queue: Armando Montanez <amontanez@google.com>
diff --git a/pw_transfer/transfer.cc b/pw_transfer/transfer.cc index 5b56b35..152ddc7 100644 --- a/pw_transfer/transfer.cc +++ b/pw_transfer/transfer.cc
@@ -76,7 +76,9 @@ static_cast<unsigned>(chunk.transfer_id), static_cast<int>(status.code())); } - transfer.Finish(status).IgnoreError(); + if (transfer.active()) { + transfer.Finish(status).IgnoreError(); + } return; }