commit | f7a708fcc2132d60b3fde90a83deaab452ad2836 | [log] [tgz] |
---|---|---|
author | Ryan Savitski <rsavitski@google.com> | Thu Mar 12 18:34:54 2020 +0000 |
committer | Ryan Savitski <rsavitski@google.com> | Thu Mar 12 18:46:21 2020 +0000 |
tree | aa286e9ad1fa6a64cca874cdd22b5e0eb5539588 | |
parent | 0c63cc1fc9bff5e909a7175e19890cc0cdc17290 [diff] |
heap profilers: reject data sources with unparsable cmdlines in cfgs For logical parity with aosp/1254587. Same argument - fail fast on invalid configs, instead of trying to degrade (and deal with associated edge cases). I don't think this does anything in practice at the time of writing. NormalizeCmdLine() should always succeed unless there's a bug in the caller (only error case is not being null-terminated afaict). Test: profiling by cmdline not obviously broken, tried: tools/heap_profile -i 4096 --name system_server -d 10000 Change-Id: I1658fe9bc7c07b5210e6c219a6976f6e8e40246f
Perfetto is an open-source project for performance instrumentation and tracing of Linux/Android/Chrome platforms and user-space apps.
See www.perfetto.dev for docs.
See /docs/contributing.md for instructions.
The source-of-truth repo is Android's Gerrit. The GitHub repo is a read-only mirror.
You can reach us on our Discord channel. If you prefer using IRC we have an experimental Discord <> IRC bridge synced with #perfetto-dev
on Freenode.