commit d410254dbc52f829846eedee496ac31cd0b1d076
author Primiano Tucci <primiano@google.com> Tue Jan 26 19:52:06 2021 +0100
committer Primiano Tucci <primiano@google.com> Tue Jan 26 19:52:06 2021 +0100
tree bf3fdf4c2437e919ca898360a3cef782100ab48c
parent 1bcc9a4f4481ceb93357731057bf45136dbe6dbe

service: allow bugreports to steal write_into_file traces

This is a follow-up to aosp/1515497. Previously we didn't
allow the --save-for-bugreport feature to steal traces
marked as write_into_file. That was because a trace
might have been partially written on disk and that would
make the bugreport re-routing more difficult (also
undesitable given those traces can be ~GB).
This CL softens the check allowing to steal also those
traces, but only if no data has been written yet.
The problem is that Traceur (System Tracing App), uses
write_into_file && --detach both for long and ring-buffer
traces (to keep the code path more uniform).
In ring-buffer mode, traceur sets the file_write_period_ms
to 7days (which really means, only save at the end), to
maintain the ring-buffer behavior.
The alternative would be a more invasive change to traceur
AND making our cmdline more awkward, as we would have to
support both "--detach + path, but only if write_into_file"
and "--attach + path, but only if !write_into_file"

Bug: 175591887
Bug: 170334305
Test: perfetto_integrationtests --gtest_filter=PerfettoTest.SaveForBugreport*
Change-Id: I9b3dbb2c1c27e80af3c25eba35ac8fc0d3992a6a