Google Git
Sign in
android / platform / external / perfetto / 7076286ad6373cdc79b989652929236f8e9841ef
commit7076286ad6373cdc79b989652929236f8e9841ef[log] [tgz]
authorDaniele Di Proietto <ddiproietto@google.com>Wed Nov 02 10:16:11 2022 +0000
committerDaniele Di Proietto <ddiproietto@google.com>Thu Nov 17 16:36:12 2022 +0000
tree5ffa91e66210c4cff6f103df585c2df3f4de6871
parentd85b69a13e9500910d715be5348dedb5f3fbe002 [diff]
heapprofd: Fix crash when tracing service disconnects

When the tracing service (traced) disconnects (because it crashes or
other reasons), if heapprofd has an active client, it will crash,
because:

* HeapprofdProducer::Restart() is executed.
* HeapprofdProducer destructor destroys its unwinding_workers_
* UnwindingWorker destroys its members. In order:
  * thread_task_runner_ is destroyed, so that the thread is stopped.
  * (If there's one connected client) client_data_ is destroyed.
  * ClientData includes a UnixSocket, which calls PostTask on
    thread_task_runner_.
  * thread_task_runner_ was destroyed earlier.

This patch makes fixes the problem by destroying client_data_ (on
thread_task_runner_) before destroying the thread_task_runner_ itself.

Bug: 233338564
Bug: 155759761
Change-Id: Id1874abbff8f7a7b702542a943a8de3f3a52277a
(cherry picked from commit abc9d3ea914ba24e4219fef68a67aca65b8c23a5)
Merged-In: Id1874abbff8f7a7b702542a943a8de3f3a52277a
2 files changed
tree: 5ffa91e66210c4cff6f103df585c2df3f4de6871
  1. .github/
  2. bazel/
  3. build_overrides/
  4. buildtools/
  5. debian/
  6. docs/
  7. examples/
  8. gn/
  9. include/
  10. infra/
  11. protos/
  12. python/
  13. src/
  14. test/
  15. tools/
  16. ui/
  17. .clang-format
  18. .clang-tidy
  19. .gitattributes
  20. .gitignore
  21. .gn
  22. .style.yapf
  23. Android.bp
  24. Android.bp.extras
  25. BUILD
  26. BUILD.extras
  27. BUILD.gn
  28. CHANGELOG
  29. codereview.settings
  30. DIR_METADATA
  31. heapprofd.rc
  32. LICENSE
  33. meson.build
  34. METADATA
  35. MODULE_LICENSE_APACHE2
  36. OWNERS
  37. perfetto.rc
  38. PerfettoIntegrationTests.xml
  39. PRESUBMIT.py
  40. README.chromium
  41. README.md
  42. TEST_MAPPING
  43. traced_perf.rc
  44. WORKSPACE
README.md

Perfetto - System profiling, app tracing and trace analysis

Perfetto is a production-grade open-source stack for performance instrumentation and trace analysis. It offers services and libraries and for recording system-level and app-level traces, native + java heap profiling, a library for analyzing traces using SQL and a web-based UI to visualize and explore multi-GB traces.

See https://perfetto.dev/docs or the /docs/ directory for documentation.