commit d23f3581eab9066c0e833cb064a5a7c5ec0704ca
author Diego Ismirlian <dismirlian@gmail.com> Thu Dec 10 12:59:56 2020 -0300
committer GitHub <noreply@github.com> Thu Dec 10 07:59:56 2020 -0800
tree 612567d0054d345073999cb1efa4506a6bf91613
parent e2856b9111bbdb68822e9cbc964f6e99693dfa4f

[efr32] radio: fix otPlatRadioGetTransmitPower (#5932)

The efr32 platform shows the following behavior:

> txpower -10
Done
>
> txpower
-113 dBm
Done

The bug is caused by the C promotion rules during the division of
int16_t by unsigned in otPlatRadioGetTransmitPower. This commit fixes
the issue.

examples/platforms/efr32/src/radio.c

diff --git a/examples/platforms/efr32/src/radio.c b/examples/platforms/efr32/src/radio.c
index 5621fb9..44e8380 100644
--- a/examples/platforms/efr32/src/radio.c
+++ b/examples/platforms/efr32/src/radio.c
@@ -1126,7 +1126,7 @@
 
     // RAIL_GetTxPowerDbm() returns power in deci-dBm (0.1dBm)
     // Divide by 10 because aPower is supposed be in units dBm
-    *aPower = RAIL_GetTxPowerDbm(gRailHandle) / 10U;
+    *aPower = RAIL_GetTxPowerDbm(gRailHandle) / 10;
 
 exit:
     return error;
@@ -1140,7 +1140,7 @@
 
     // RAIL_SetTxPowerDbm() takes power in units of deci-dBm (0.1dBm)
     // Divide by 10 because aPower is supposed be in units dBm
-    status = RAIL_SetTxPowerDbm(gRailHandle, ((RAIL_TxPower_t)aPower) * 10U);
+    status = RAIL_SetTxPowerDbm(gRailHandle, ((RAIL_TxPower_t)aPower) * 10);
     assert(status == RAIL_STATUS_NO_ERROR);
 
     return OT_ERROR_NONE;