commit 0e812192e2edd11b84c01307eb310b7fd7ba7c4e
author Robert Quattlebaum <darco@deepdarc.com> Fri Feb 17 13:27:23 2017 -0800
committer Jonathan Hui <jonhui@nestlabs.com> Fri Feb 17 13:27:23 2017 -0800
tree 1ca81f6079a1124f602910a71f985ea7dd9c1522
parent 5ca4b9908ae499bc154b3ee4b64350a0895df27c

Let platforms specify linker section for version string (#1334)

`PLATFORM_VERSION_ATTR_PREFIX` and `PLATFORM_VERSION_ATTR_SUFFIX` are
intended to be used to specify compiler directives to indicate
what linker section the platform version string should be stored.

This is useful for specifying an exact locaiton of where the version
string will be located so that it can be easily retrieved from the
raw firmware image.

If `PLATFORM_VERSION_ATTR_PREFIX` is unspecified, the keyword `static`
is used instead.

If both are unspecified, the location of the string in the firmware
image will be undefined and may change.

src/core/openthread.cpp

diff --git a/src/core/openthread.cpp b/src/core/openthread.cpp
index a637f6c..f7fb052 100644
--- a/src/core/openthread.cpp
+++ b/src/core/openthread.cpp
@@ -1155,16 +1155,39 @@
 
 const char *otGetVersionString(void)
 {
-    static const char sVersion[] =
+    /**
+     * PLATFORM_VERSION_ATTR_PREFIX and PLATFORM_VERSION_ATTR_SUFFIX are
+     * intended to be used to specify compiler directives to indicate
+     * what linker section the platform version string should be stored.
+     *
+     * This is useful for specifying an exact locaiton of where the version
+     * string will be located so that it can be easily retrieved from the
+     * raw firmware image.
+     *
+     * If PLATFORM_VERSION_ATTR_PREFIX is unspecified, the keyword `static`
+     * is used instead.
+     *
+     * If both are unspecified, the location of the string in the firmware
+     * image will be undefined and may change.
+     */
+
+#ifdef PLATFORM_VERSION_ATTR_PREFIX
+    PLATFORM_VERSION_ATTR_PREFIX
+#else
+    static
+#endif
+    const char sVersion[] =
         PACKAGE_NAME "/" PACKAGE_VERSION
 #ifdef  PLATFORM_INFO
         "; " PLATFORM_INFO
 #endif
 #if defined(__DATE__)
-        "; " __DATE__ " " __TIME__;
-#else
-        ;
+        "; " __DATE__ " " __TIME__
 #endif
+#ifdef PLATFORM_VERSION_ATTR_SUFFIX
+        PLATFORM_VERSION_ATTR_SUFFIX
+#endif
+        ; // Trailing semicolon to end statement.
 
     return sVersion;
 }