commit f2280e03e21d37ab9bf3b8f0ebeea42dda7fdf37
author Gert Wollny <gert.wollny@collabora.com> Sun Aug 02 19:35:58 2020 +0200
committer Marge Bot <eric+marge@anholt.net> Wed Sep 16 08:30:41 2020 +0000
tree 99268fbcfa8adfbbe3dde8df9369d5b5a60573cd
parent daaa71924ad38019f12e5ed4aba1ddce0982846e

r600/sfn: Fix ordering of tex param moves

Both moves should happen in the same instuction group, otherwise the
lod/bias value will be overwritten by the shadow compare value.

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6706>

src/gallium/drivers/r600/sfn/sfn_emittexinstruction.cpp

diff --git a/src/gallium/drivers/r600/sfn/sfn_emittexinstruction.cpp b/src/gallium/drivers/r600/sfn/sfn_emittexinstruction.cpp
index 8764d8a..0fe9db2 100644
--- a/src/gallium/drivers/r600/sfn/sfn_emittexinstruction.cpp
+++ b/src/gallium/drivers/r600/sfn/sfn_emittexinstruction.cpp
@@ -539,15 +539,15 @@
                  << "' (" << __func__ << ")\n";
 
    auto tex_op = TexInstruction::sample_l;
-   emit_instruction(new AluInstruction(op1_mov, src.coord.reg_i(3), src.lod,
-                                       {alu_last_instr, alu_write}));
-
    if (instr->is_shadow)  {
       emit_instruction(new AluInstruction(op1_mov, src.coord.reg_i(2), src.comperator,
-                       {alu_last_instr, alu_write}));
+                       {alu_write}));
       tex_op = TexInstruction::sample_c_l;
    }
 
+   emit_instruction(new AluInstruction(op1_mov, src.coord.reg_i(3), src.lod,
+                                       {alu_last_instr, alu_write}));
+
    auto sampler = get_samplerr_id(instr->sampler_index, src.sampler_deref);
    assert(!sampler.indirect && "Indirect sampler selection not yet supported");
 
@@ -571,14 +571,15 @@
 
    std::array<uint8_t, 4> in_swizzle = {0,1,2,3};
 
+   if (instr->is_shadow) {
+      emit_instruction(new AluInstruction(op1_mov, src.coord.reg_i(2), src.comperator,
+                                          {alu_write}));
+      tex_op = TexInstruction::sample_c_lb;
+   }
+
    emit_instruction(new AluInstruction(op1_mov, src.coord.reg_i(3), src.bias,
                                        {alu_last_instr, alu_write}));
 
-   if (instr->is_shadow) {
-      emit_instruction(new AluInstruction(op1_mov, src.coord.reg_i(2), src.comperator,
-                                          {alu_last_instr, alu_write}));
-      tex_op = TexInstruction::sample_c_lb;
-   }
 
    GPRVector tex_src(src.coord, in_swizzle);