commit cfc0e15b9bdc5cde158083c04de3e9b7ec1e9e60
author Iago Toral Quiroga <itoral@igalia.com> Tue Mar 24 10:35:05 2020 +0100
committer Marge Bot <eric+marge@anholt.net> Tue Oct 13 21:21:28 2020 +0000
tree 0afd6246de35f7aed6be43d0b8158ee665b503f2
parent 19841fd5502b0b69f97ab11738b81f6732fce2b8

v3dv: make sure we only expose transfer features for formats we can use

We were already doing this, but this makes it more explicit.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6766>

src/broadcom/vulkan/v3dv_formats.c

diff --git a/src/broadcom/vulkan/v3dv_formats.c b/src/broadcom/vulkan/v3dv_formats.c
index 0d1faaf..d48fe55 100644
--- a/src/broadcom/vulkan/v3dv_formats.c
+++ b/src/broadcom/vulkan/v3dv_formats.c
@@ -351,8 +351,7 @@
       return 0;
    }
 
-   VkFormatFeatureFlags flags = VK_FORMAT_FEATURE_TRANSFER_SRC_BIT |
-                                VK_FORMAT_FEATURE_TRANSFER_DST_BIT;
+   VkFormatFeatureFlags flags = 0;
 
    if (v3dv_format->tex_type != TEXTURE_DATA_FORMAT_NO) {
       flags |= VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT |
@@ -381,6 +380,11 @@
          flags |= VK_FORMAT_FEATURE_STORAGE_IMAGE_ATOMIC_BIT;
    }
 
+   if (flags) {
+      flags |= VK_FORMAT_FEATURE_TRANSFER_SRC_BIT |
+               VK_FORMAT_FEATURE_TRANSFER_DST_BIT;
+   }
+
    return flags;
 }