commit c5d07802dce5217c9b4220f287ba173507903470
author Iago Toral Quiroga <itoral@igalia.com> Fri Jul 17 10:30:35 2020 +0200
committer Marge Bot <eric+marge@anholt.net> Tue Oct 13 21:21:32 2020 +0000
tree 18a6d7f1c0333ce31a6c0806ca96f7c85b076f88
parent c4564f62aa8fce78eb4be0fe4a342b677ddcd9c7

v3dv: only clear depth/stencil attachments if any aspect needs clearing

When we can't perform the clears using the TLB and fallback to
vkCmdClearAttachments make sure we only emit the clear if any of
the depth/stencil aspects actually needs it.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6766>

src/broadcom/vulkan/v3dv_cmd_buffer.c

diff --git a/src/broadcom/vulkan/v3dv_cmd_buffer.c b/src/broadcom/vulkan/v3dv_cmd_buffer.c
index 8dc29aa..1a384e0 100644
--- a/src/broadcom/vulkan/v3dv_cmd_buffer.c
+++ b/src/broadcom/vulkan/v3dv_cmd_buffer.c
@@ -2046,11 +2046,13 @@
          if (att->desc.stencilLoadOp != VK_ATTACHMENT_LOAD_OP_CLEAR)
             aspects &= ~VK_IMAGE_ASPECT_STENCIL_BIT;
 
-         atts[att_count].aspectMask = aspects;
-         atts[att_count].colorAttachment = 0; /* Ignored */
-         atts[att_count].clearValue =
-            state->attachments[ds_att_idx].vk_clear_value;
-         att_count++;
+         if (aspects) {
+            atts[att_count].aspectMask = aspects;
+            atts[att_count].colorAttachment = 0; /* Ignored */
+            atts[att_count].clearValue =
+               state->attachments[ds_att_idx].vk_clear_value;
+            att_count++;
+         }
       }
    }