commit b2a21febe0416d7d5506fdc9592b7b4c10431077
author Vinson Lee <vlee@freedesktop.org> Tue Oct 27 16:21:11 2020 -0700
committer Marge Bot <eric+marge@anholt.net> Mon Nov 02 18:37:00 2020 +0000
tree 8d5d449352f674df0c1e80e94a6285c9056be2c4
parent 1eda842318704ed477c7669d2c8e94d6394792b9

os: Fix open result check.

Fix defect reported by Coverity Scan.

Argument cannot be negative (NEGATIVE_RETURNS)
negative_returns: f is passed to a parameter that cannot be negative.

CID: 1364709
Fixes: 13fa0513569d ("auxiliary/os: add new os_get_command_line() function")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7344>

src/gallium/auxiliary/os/os_process.c

diff --git a/src/gallium/auxiliary/os/os_process.c b/src/gallium/auxiliary/os/os_process.c
index f2721a0..b00ff2b 100644
--- a/src/gallium/auxiliary/os/os_process.c
+++ b/src/gallium/auxiliary/os/os_process.c
@@ -122,7 +122,7 @@
    }
 #elif defined(PIPE_OS_LINUX)
    int f = open("/proc/self/cmdline", O_RDONLY);
-   if (f) {
+   if (f != -1) {
       const int n = read(f, cmdline, size - 1);
       int i;
       assert(n < size);