commit b03fdca2e003d4b866bf2a2d14b1a475588e0500
author Eric Anholt <eric@anholt.net> Mon Oct 19 12:17:38 2020 -0700
committer Marge Bot <eric+marge@anholt.net> Tue Oct 20 22:16:59 2020 +0000
tree 73aebe22d703a442638dcfacfcc4a3e9dbb0482c
parent d384f3be4c0c753c38498f9cf8f66dedafda0024

turnip: Add error path handling for descriptor pool init.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7224>

src/freedreno/vulkan/tu_descriptor_set.c

diff --git a/src/freedreno/vulkan/tu_descriptor_set.c b/src/freedreno/vulkan/tu_descriptor_set.c
index 7262fd0..151ef92 100644
--- a/src/freedreno/vulkan/tu_descriptor_set.c
+++ b/src/freedreno/vulkan/tu_descriptor_set.c
@@ -543,6 +543,7 @@
    struct tu_descriptor_pool *pool;
    uint64_t size = sizeof(struct tu_descriptor_pool);
    uint64_t bo_size = 0, bo_count = 0, dynamic_count = 0;
+   VkResult ret;
 
    for (unsigned i = 0; i < pCreateInfo->poolSizeCount; ++i) {
       if (pCreateInfo->pPoolSizes[i].type != VK_DESCRIPTOR_TYPE_SAMPLER)
@@ -581,19 +582,25 @@
    }
 
    if (bo_size) {
-      VkResult ret;
-
       ret = tu_bo_init_new(device, &pool->bo, bo_size, true);
-      assert(ret == VK_SUCCESS);
+      if (ret)
+         goto fail_alloc;
 
       ret = tu_bo_map(device, &pool->bo);
-      assert(ret == VK_SUCCESS);
+      if (ret)
+         goto fail_map;
    }
    pool->size = bo_size;
    pool->max_entry_count = pCreateInfo->maxSets;
 
    *pDescriptorPool = tu_descriptor_pool_to_handle(pool);
    return VK_SUCCESS;
+
+fail_map:
+   tu_bo_finish(device, &pool->bo);
+fail_alloc:
+   vk_object_free(&device->vk, pAllocator, pool);
+   return ret;
 }
 
 void