commit aa989aed6d68d50ff7900cfca4078ed4771c4b40
author Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Thu Jul 30 20:22:56 2020 -0400
committer Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Fri Jul 31 10:14:59 2020 -0400
tree a93a3ff2d4f417e754680bdd32632a6a5febb7d2
parent cf8a8b764e53c3c81ca9ec6e799281b248954ffe

pan/bit: Update f32->f16 convert test

Needs a second argument to be consistent with the real IR and the
hardware instruction.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Fixes: 8a4efe2d730 ("pan/bi: Pack second argument of F32_TO_F16")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6142>

src/panfrost/bifrost/test/bi_interpret.c

diff --git a/src/panfrost/bifrost/test/bi_interpret.c b/src/panfrost/bifrost/test/bi_interpret.c
index 43777ca..a8fadb3 100644
--- a/src/panfrost/bifrost/test/bi_interpret.c
+++ b/src/panfrost/bifrost/test/bi_interpret.c
@@ -489,13 +489,7 @@
                         dest.i32 = bit_as_int32(ins->src_types[0], srcs[0], comp, ins->roundmode);
                 else if (ins->dest_type == nir_type_float16) {
                         dest.u16[0] = bit_as_float16(ins->src_types[0], srcs[0], ins->swizzle[0][0]);
-
-                        if (ins->src_types[0] == nir_type_float32) {
-                                /* TODO: Second argument */
-                                dest.u16[1] = 0;
-                        } else {
-                                dest.u16[1] = bit_as_float16(ins->src_types[0], srcs[0], ins->swizzle[0][1]);
-                        }
+                        dest.u16[1] = bit_as_float16(ins->src_types[0], srcs[0], ins->swizzle[0][1]);
                 } else if (ins->dest_type == nir_type_uint16) {
                         dest.u16[0] = bit_as_uint16(ins->src_types[0], srcs[0], ins->swizzle[0][0], ins->roundmode);
                         dest.u16[1] = bit_as_uint16(ins->src_types[0], srcs[0], ins->swizzle[0][1], ins->roundmode);

src/panfrost/bifrost/test/bi_test_pack.c

diff --git a/src/panfrost/bifrost/test/bi_test_pack.c b/src/panfrost/bifrost/test/bi_test_pack.c
index 81bf0b0..9a9f991 100644
--- a/src/panfrost/bifrost/test/bi_test_pack.c
+++ b/src/panfrost/bifrost/test/bi_test_pack.c
@@ -488,6 +488,13 @@
                         ins.swizzle[0][0] = cx;
                         ins.swizzle[0][1] = cy;
 
+                        if (to_size == 16 && from_size == 32) {
+                                ins.src_types[1] = ins.src_types[0];
+                                ins.src[1] = ins.src[0];
+                        } else {
+                                ins.src[1] = ins.src_types[1] = 0;
+                        }
+
                         bit_test_single(dev, &ins, input, FMA, debug);
                 }
         }