commit a575bb136973901bdbe7478c77aa5a0ad5d7464d
author Vinson Lee <vlee@freedesktop.org> Wed Oct 21 16:09:27 2020 -0700
committer Vinson Lee <vlee@freedesktop.org> Fri Oct 30 18:33:39 2020 -0700
tree 6feae452a27def10e9be4f0fe372d30ba2f625d8
parent 0a4c1db926cc359254ed4a35cbc77f18c53bdd99

draw: Remove draw_install_aaline_stage dead code.

Remove dead code left over from commit dbb2cf388b79 ("draw: simplify
(and correct) aaline fallback (v2)").

Fix defect reported by Coverity Scan.

Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement:
(*aaline->stage.destroy)(&a....

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7265>

src/gallium/auxiliary/draw/draw_pipe_aaline.c

diff --git a/src/gallium/auxiliary/draw/draw_pipe_aaline.c b/src/gallium/auxiliary/draw/draw_pipe_aaline.c
index d380b42..de6f970 100644
--- a/src/gallium/auxiliary/draw/draw_pipe_aaline.c
+++ b/src/gallium/auxiliary/draw/draw_pipe_aaline.c
@@ -747,7 +747,7 @@
     */
    aaline = draw_aaline_stage(draw);
    if (!aaline)
-      goto fail;
+      return FALSE;
 
    /* save original driver functions */
    aaline->driver_create_fs_state = pipe->create_fs_state;
@@ -764,10 +764,4 @@
    draw->pipeline.aaline = &aaline->stage;
 
    return TRUE;
-
-fail:
-   if (aaline)
-      aaline->stage.destroy(&aaline->stage);
-
-   return FALSE;
 }