commit 99bb2a4de66fa662fb4bcb29df8e2749972ee986
author Jason Ekstrand <jason@jlekstrand.net> Mon Aug 24 11:26:18 2020 -0500
committer Marge Bot <eric+marge@anholt.net> Thu Sep 03 18:02:50 2020 +0000
tree 3259c62331c7c6eed92c3a4b0df7502e10607c36
parent beefd37021edd707274625def137bed0df6fb65f

nir/opt_deref: Don't remove casts with alignment information

Generally, if a cast has alignment information, that information is
useful and we don't want to loose it.

Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6472>

src/compiler/nir/nir_deref.c

diff --git a/src/compiler/nir/nir_deref.c b/src/compiler/nir/nir_deref.c
index ad0380a..5b9f97b 100644
--- a/src/compiler/nir/nir_deref.c
+++ b/src/compiler/nir/nir_deref.c
@@ -924,6 +924,9 @@
    if (!parent)
       return false;
 
+   if (cast->cast.align_mul > 0)
+      return false;
+
    if (!glsl_type_is_struct(parent->type))
       return false;
 
@@ -954,6 +957,12 @@
    if (!is_trivial_deref_cast(cast))
       return progress;
 
+   /* If this deref still contains useful alignment information, we don't want
+    * to delete it.
+    */
+   if (cast->cast.align_mul > 0)
+      return progress;
+
    bool trivial_array_cast = is_trivial_array_deref_cast(cast);
 
    assert(cast->dest.is_ssa);