commit 93b8cdfe8bfb87335afc34458dcf1031b934f51a
author Vinson Lee <vlee@freedesktop.org> Mon Sep 07 18:34:46 2020 -0700
committer Vinson Lee <vlee@freedesktop.org> Mon Sep 28 15:34:01 2020 -0700
tree 28f8071321b0c0c63a746615802ad1066694f807
parent 1d71b1a311239ecbc2dbdd241abcf64a7345dc41

anv: Check file descriptor before closing.

Fix defect reported by Coverity Scan.

Argument cannot be negative (NEGATIVE_RETURNS)
negative_returns: fd is passed to a parameter that cannot be negative

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6643>

src/intel/vulkan/anv_queue.c

diff --git a/src/intel/vulkan/anv_queue.c b/src/intel/vulkan/anv_queue.c
index fdf10f2..9a38ca8 100644
--- a/src/intel/vulkan/anv_queue.c
+++ b/src/intel/vulkan/anv_queue.c
@@ -1915,7 +1915,8 @@
     *
     * If the import fails, we leave the file descriptor open.
     */
-   close(fd);
+   if (fd != -1)
+      close(fd);
 
    if (pImportFenceFdInfo->flags & VK_FENCE_IMPORT_TEMPORARY_BIT) {
       anv_fence_impl_cleanup(device, &fence->temporary);