commit 92831412d95a1af33829d83a4d5cd0e33f5e3494
author Andreas Baierl <ichgeh@imkreisrum.de> Wed Sep 23 16:59:19 2020 +0200
committer Marge Bot <eric+marge@anholt.net> Mon Sep 28 07:35:07 2020 +0000
tree 7f1b2487b23a64e10be169160df1a4a3af9d7585
parent 9a221095d270822aab734067956bc51658452f6b

lima: set clear depth value to 0x00ffffff as default

According to the specs, the initial depth value for a
depth buffer clear is 1. Use 0x00ffffff like the blob does.

We can remove setting this value in lima_clear, because it's
set during job creation now.

Fixes the following dEQP tests:

dEQP-GLES2.functional.fbo.render.shared_depthbuffer.rbo_rgb565_depth_component16
dEQP-GLES2.functional.fbo.render.shared_depthbuffer.rbo_rgb5_a1_depth_component16
dEQP-GLES2.functional.fbo.render.shared_depthbuffer.rbo_rgb4_depth_component16
dEQP-GLES2.functional.fbo.render.shared_depthbuffer.tex2d_rgba_depth_component16
dEQP-GLES2.functional.fbo.render.shared_depthbuffer.tex2d_rgb_depth_component16

Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com>
Signed-off-by: Andreas Baierl <ichgeh@imkreisrum.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6842>

src/gallium/drivers/lima/lima_draw.c

diff --git a/src/gallium/drivers/lima/lima_draw.c b/src/gallium/drivers/lima/lima_draw.c
index 8b7a868..8737e5e 100644
--- a/src/gallium/drivers/lima/lima_draw.c
+++ b/src/gallium/drivers/lima/lima_draw.c
@@ -175,8 +175,7 @@
       clear->depth = util_pack_z(PIPE_FORMAT_Z24X8_UNORM, depth);
       if (zsbuf)
          zsbuf->reload &= ~PIPE_CLEAR_DEPTH;
-   } else
-      clear->depth = 0x00ffffff;
+   }
 
    if (buffers & PIPE_CLEAR_STENCIL) {
       clear->stencil = stencil;

src/gallium/drivers/lima/lima_job.c

diff --git a/src/gallium/drivers/lima/lima_job.c b/src/gallium/drivers/lima/lima_job.c
index 6d260f6..bd56d29 100644
--- a/src/gallium/drivers/lima/lima_job.c
+++ b/src/gallium/drivers/lima/lima_job.c
@@ -100,6 +100,8 @@
    s->damage_rect.minx = s->damage_rect.miny = 0xffff;
    s->damage_rect.maxx = s->damage_rect.maxy = 0;
 
+   s->clear.depth = 0x00ffffff;
+
    for (int i = 0; i < 2; i++) {
       util_dynarray_init(s->gem_bos + i, s);
       util_dynarray_init(s->bos + i, s);