commit 8cf00244328c1697b93ed0eb57e009f283d03269
author Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Mon Oct 05 14:25:10 2020 -0700
committer Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Wed Oct 21 12:00:09 2020 -0700
tree 65cc52f01c161900fd5cb6d8125076e17070a30c
parent 8033200560f6d76b1f84480cc0df809112389686

nir: Use a switch in nir_lower_explicit_io_instr

Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7255>

src/compiler/nir/nir_lower_io.c

diff --git a/src/compiler/nir/nir_lower_io.c b/src/compiler/nir/nir_lower_io.c
index 318e2a0..cddfaada1 100644
--- a/src/compiler/nir/nir_lower_io.c
+++ b/src/compiler/nir/nir_lower_io.c
@@ -1468,7 +1468,8 @@
       align_offset = 0;
    }
 
-   if (intrin->intrinsic == nir_intrinsic_load_deref) {
+   switch (intrin->intrinsic) {
+   case nir_intrinsic_load_deref: {
       nir_ssa_def *value;
       if (vec_stride > scalar_size) {
          nir_ssa_def *comps[NIR_MAX_VEC_COMPONENTS] = { NULL, };
@@ -1489,7 +1490,10 @@
                                         intrin->num_components);
       }
       nir_ssa_def_rewrite_uses(&intrin->dest.ssa, nir_src_for_ssa(value));
-   } else if (intrin->intrinsic == nir_intrinsic_store_deref) {
+      break;
+   }
+
+   case nir_intrinsic_store_deref: {
       assert(intrin->src[1].is_ssa);
       nir_ssa_def *value = intrin->src[1].ssa;
       nir_component_mask_t write_mask = nir_intrinsic_write_mask(intrin);
@@ -1511,10 +1515,15 @@
                                  align_mul, align_offset,
                                  value, write_mask);
       }
-   } else {
+      break;
+   }
+
+   default: {
       nir_ssa_def *value =
          build_explicit_io_atomic(b, intrin, addr, addr_format);
       nir_ssa_def_rewrite_uses(&intrin->dest.ssa, nir_src_for_ssa(value));
+      break;
+   }
    }
 
    nir_instr_remove(&intrin->instr);