commit 8236fa3ff166053f7e47a1a768631d3e9bf800bd
author Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Fri Aug 14 12:09:05 2020 -0400
committer Marge Bot <eric+marge@anholt.net> Mon Aug 17 11:43:52 2020 +0000
tree 68a4447232e5fce0d67d90a08361c1c20f1d9ce7
parent 9cc81ea0c209078b02e1eb62a27d4c31b292ba3d

panfrost: Make attribute-buffer map explicit

This helps decouple the attribute and attribute buffer emission.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6326>

src/gallium/drivers/panfrost/pan_cmdstream.c

diff --git a/src/gallium/drivers/panfrost/pan_cmdstream.c b/src/gallium/drivers/panfrost/pan_cmdstream.c
index 41abf57..28607b4 100644
--- a/src/gallium/drivers/panfrost/pan_cmdstream.c
+++ b/src/gallium/drivers/panfrost/pan_cmdstream.c
@@ -1348,6 +1348,7 @@
          * vertex buffer mask and instancing. Twice as much room is allocated,
          * for a worst case of NPOT_DIVIDEs which take up extra slot */
         union mali_attr attrs[PIPE_MAX_ATTRIBS * 2];
+        unsigned attrib_to_buffer[PIPE_MAX_ATTRIBS] = { 0 };
         unsigned k = 0;
 
         for (unsigned i = 0; i < so->num_elements; ++i) {
@@ -1358,11 +1359,7 @@
 
                 struct pipe_vertex_element *elem = &so->pipe[i];
                 unsigned vbi = elem->vertex_buffer_index;
-
-                /* The exception to 1:1 mapping is that we can have multiple
-                 * entries (NPOT divisors), so we fixup anyways */
-
-                so->hw[i].index = k;
+                attrib_to_buffer[i] = k;
 
                 if (!(ctx->vb_mask & (1 << vbi)))
                         continue;
@@ -1470,6 +1467,7 @@
                         src_offset -= buf->stride * start;
 
                 so->hw[i].src_offset = src_offset;
+                so->hw[i].index = attrib_to_buffer[i];
         }