commit 7e862670efb8c3ab7eb50173d302379f42cd63fe
author Vinson Lee <vlee@freedesktop.org> Mon Sep 28 16:01:03 2020 -0700
committer Marge Bot <eric+marge@anholt.net> Sat Oct 03 01:04:28 2020 +0000
tree 9dcd267e9e71edeccf32a0d68c311e930f6cd7c8
parent 9660427ab7b3fd18a250189667b826086529160e

radv: Fix asserts using assign instead of compare.

Fix defects reported by Coverity Scan.

Assign instead of compare (PW.ASSIGN_WHERE_COMPARE_MEANT)
assign_where_compare_meant: use of "=" where "==" may have been
intended

Fixes: d8cdcd4adf7a ("radv: use syncobj for wsi fence")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6902>

src/amd/vulkan/radv_wsi_display.c

diff --git a/src/amd/vulkan/radv_wsi_display.c b/src/amd/vulkan/radv_wsi_display.c
index 1f73209..868298d 100644
--- a/src/amd/vulkan/radv_wsi_display.c
+++ b/src/amd/vulkan/radv_wsi_display.c
@@ -288,7 +288,7 @@
 
 	RADV_FROM_HANDLE(radv_fence, fence, *_fence);
 
-	assert(fence->permanent.kind = RADV_FENCE_SYNCOBJ);
+	assert(fence->permanent.kind == RADV_FENCE_SYNCOBJ);
 
 	if (device->ws->export_syncobj(device->ws, fence->permanent.syncobj, &fd)) {
 		ret = VK_ERROR_OUT_OF_HOST_MEMORY;
@@ -331,7 +331,7 @@
 
 	RADV_FROM_HANDLE(radv_fence, fence, *_fence);
 
-	assert(fence->permanent.kind = RADV_FENCE_SYNCOBJ);
+	assert(fence->permanent.kind == RADV_FENCE_SYNCOBJ);
 
 	if (device->ws->export_syncobj(device->ws, fence->permanent.syncobj, &fd)) {
 		ret = VK_ERROR_OUT_OF_HOST_MEMORY;