commit 7278f900394e7d8124075557a8008f14bebff20e
author Vinson Lee <vlee@freedesktop.org> Mon Oct 26 19:55:07 2020 -0700
committer Vinson Lee <vlee@freedesktop.org> Mon Nov 02 17:48:56 2020 -0800
tree a61a6f7b87b9df63a80e57b694f75e01be6c1668
parent 78a420ce46716bf788b4a6bfc85ae226e0c6c804

gallium: Remove duplicate resource variable.

Fix defect reported by Coverity Scan.

Evaluation order violation (EVALUATION_ORDER)
write_write_typo: In resource = resource =
ntt_ureg_src_indirect(c, ureg_src_register(TGSI_FILE_IMAGE, 0U),
instr->src[0]), resource is written twice with the same value.

Fixes: 34cc6a804ec9 ("gallium: Add a nir-to-TGSI pass.")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7326>

src/gallium/auxiliary/nir/nir_to_tgsi.c

diff --git a/src/gallium/auxiliary/nir/nir_to_tgsi.c b/src/gallium/auxiliary/nir/nir_to_tgsi.c
index 2311927..d74eafd 100644
--- a/src/gallium/auxiliary/nir/nir_to_tgsi.c
+++ b/src/gallium/auxiliary/nir/nir_to_tgsi.c
@@ -1222,8 +1222,8 @@
                                    nir_intrinsic_image_array(instr));
 
    struct ureg_src resource =
-      resource = ntt_ureg_src_indirect(c, ureg_src_register(TGSI_FILE_IMAGE, 0),
-                                       instr->src[0]);
+      ntt_ureg_src_indirect(c, ureg_src_register(TGSI_FILE_IMAGE, 0),
+                            instr->src[0]);
 
    struct ureg_dst dst;
    if (instr->intrinsic == nir_intrinsic_image_store) {