commit 55e99728e03cc8a290db4d1b97d7d512361b362c
author Danylo Piliaiev <dpiliaiev@igalia.com> Tue Feb 27 18:54:08 2024 +0100
committer Marge Bot <emma+marge@anholt.net> Wed Feb 28 12:00:33 2024 +0000
tree 4a05b57240ed40b3d92dcace7ff0a2ccee9e22dd
parent b3064f9cf43b0a128fb5cf1f611c390a0df1eb1b

tu: Do not emit zero-sized fs params

The comparison change accidentally slipped in.

Fixes a crash in:
  dEQP-VK.subgroups.size_control.framebuffer.fragment_allow_varying_subgroup_size

Fixes: 76e417ca593866080731da59c479a99542e3a529
("turnip,ir3/a750: Implement consts loading via preamble")

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27829>

src/freedreno/vulkan/tu_cmd_buffer.cc

diff --git a/src/freedreno/vulkan/tu_cmd_buffer.cc b/src/freedreno/vulkan/tu_cmd_buffer.cc
index 0386f7e..271cc18 100644
--- a/src/freedreno/vulkan/tu_cmd_buffer.cc
+++ b/src/freedreno/vulkan/tu_cmd_buffer.cc
@@ -4701,7 +4701,7 @@
       &cmd->state.program.link[MESA_SHADER_FRAGMENT];
    const struct ir3_const_state *const_state = &link->const_state;
 
-   if (const_state->num_driver_params < IR3_DP_FS_DYNAMIC)
+   if (const_state->num_driver_params <= IR3_DP_FS_DYNAMIC)
       return 0;
 
    if (const_state->offsets.driver_param + IR3_DP_FS_DYNAMIC / 4 >= link->constlen)