commit 4423552ff04647aae75dc2cc0dc0ce580b80b3a3
author Connor Abbott <cwabbott0@gmail.com> Mon Jun 10 21:59:12 2019 +0200
committer Connor Abbott <cwabbott0@gmail.com> Thu Jul 18 14:21:41 2019 +0200
tree 559f0b654dc6b9eb5442221be685e444c28a3d2c
parent 6e5e4bf0505f0723e500f2827d45c5d0191fb098

nir/lower_viewport: Check variable mode first

The location is unused for shader_temp and function_temp variables, and
due to the way we nir_lower_io_to_temproraries demotes shader_out
variables to shader_temp variables, it happened to equal
VARYING_SLOT_POS for the gl_Position temporary, which made this pass
fail with the offline compiler due to this coming before vars_to_ssa.

Reviewed-by: Qiang Yu <yuq825@gmail.com>

src/compiler/nir/nir_lower_viewport_transform.c

diff --git a/src/compiler/nir/nir_lower_viewport_transform.c b/src/compiler/nir/nir_lower_viewport_transform.c
index 94b5452..4bbc88d 100644
--- a/src/compiler/nir/nir_lower_viewport_transform.c
+++ b/src/compiler/nir/nir_lower_viewport_transform.c
@@ -56,7 +56,8 @@
                continue;
 
             nir_variable *var = nir_intrinsic_get_var(intr, 0);
-            if (var->data.location != VARYING_SLOT_POS)
+            if (var->data.mode != nir_var_shader_out ||
+                var->data.location != VARYING_SLOT_POS)
                continue;
 
             nir_builder b;