commit 3df90c7c27e1149d250bb74923ee63af47b0e1f6
author Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Mon Aug 17 14:37:44 2020 -0400
committer Tomeu Vizoso <tomeu.vizoso@collabora.com> Thu Aug 20 18:15:02 2020 +0200
tree eb35942c271b8e47a3374b1075662aed0f4f7b30
parent 373a204bdd7b6bd0d3bd1b052ef67824d1b81fa7

panfrost: Fix attribute buffer underallocation

Breaks on the pathological where everything is NPOT.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Fixes: e646c861fc6 ("panfrost: Use packs for vertex attribute buffers")
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6373>

src/gallium/drivers/panfrost/pan_cmdstream.c

diff --git a/src/gallium/drivers/panfrost/pan_cmdstream.c b/src/gallium/drivers/panfrost/pan_cmdstream.c
index 73c321c..1b0c8d7 100644
--- a/src/gallium/drivers/panfrost/pan_cmdstream.c
+++ b/src/gallium/drivers/panfrost/pan_cmdstream.c
@@ -1333,8 +1333,8 @@
         /* Worst case: everything is NPOT */
 
         struct panfrost_transfer S = panfrost_pool_alloc_aligned(&batch->pool,
-                        MALI_ATTRIBUTE_LENGTH * PIPE_MAX_ATTRIBS * 2,
-                        MALI_ATTRIBUTE_LENGTH);
+                        MALI_ATTRIBUTE_BUFFER_LENGTH * PIPE_MAX_ATTRIBS * 2,
+                        MALI_ATTRIBUTE_BUFFER_LENGTH);
 
         struct panfrost_transfer T = panfrost_pool_alloc_aligned(&batch->pool,
                         MALI_ATTRIBUTE_LENGTH * (PAN_INSTANCE_ID + 1),