commit 39d1576eef0cd1628c0afa8b778eea686d3035b7
author Vinson Lee <vlee@freedesktop.org> Tue Oct 27 15:46:26 2020 -0700
committer Vinson Lee <vlee@freedesktop.org> Fri Nov 06 19:24:05 2020 -0800
tree fa3f5254e3e09131b40ed1e7be6b828e1b234896
parent 0bc222706d3ba1ebddf9e9b90197a4fea5f71139

st/nine: Remove unnecessary NULL check.

resource cannot be NULL at this point since it has already been
dereferenced earlier.

Fix defect reported by Coverity Scan.

Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking resource suggests that it may be
null, but it has already been dereferenced on all paths leading to
the check.

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Axel Davy <davyaxel0@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7343>

src/gallium/frontends/nine/surface9.c

diff --git a/src/gallium/frontends/nine/surface9.c b/src/gallium/frontends/nine/surface9.c
index 6e786e2..ed1be08 100644
--- a/src/gallium/frontends/nine/surface9.c
+++ b/src/gallium/frontends/nine/surface9.c
@@ -834,8 +834,7 @@
 
     pipe_surface_reference(&This->surface[0], NULL);
     pipe_surface_reference(&This->surface[1], NULL);
-    if (resource)
-        NineSurface9_CreatePipeSurfaces(This);
+    NineSurface9_CreatePipeSurfaces(This);
 }