radv: ignore other blend targets if dual-source blending is enabled
Using more blend targets than specified by maxFragmentDualSrcAttachments
is invalid per the Vulkan spec.
I'm usually not a fan to workaround game bugs inside the driver but
it's really easy for us to ignore MRT1+ in the driver and that
prevents wrong behaviour.
Cc: 20.2, 20.3
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
(cherry picked from commit bc7f442d8e03919cf7f8e6a470b3c0406e11a1f9)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8014>
diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index f480a57..39605fb 100644
--- a/src/amd/vulkan/radv_pipeline.c
+++ b/src/amd/vulkan/radv_pipeline.c
@@ -555,8 +555,10 @@
/* The output for dual source blending should have the same format as
* the first output.
*/
- if (blend->mrt0_is_dual_src)
+ if (blend->mrt0_is_dual_src) {
+ assert(!(col_format >> 4));
col_format |= (col_format & 0xf) << 4;
+ }
blend->spi_shader_col_format = col_format;
blend->col_format_is_int8 = is_int8;
@@ -684,6 +686,12 @@
if (!att->colorWriteMask)
continue;
+ /* Ignore other blend targets if dual-source blending
+ * is enabled to prevent wrong behaviour.
+ */
+ if (blend.mrt0_is_dual_src)
+ continue;
+
blend.cb_target_mask |= (unsigned)att->colorWriteMask << (4 * i);
blend.cb_target_enabled_4bit |= 0xfu << (4 * i);
if (!att->blendEnable) {
