commit 101400d4495d3ab6dba4af70782698ef13b3b06c
author Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com> Thu Jul 16 15:13:08 2020 +0300
committer Marge Bot <eric+marge@anholt.net> Mon Jul 20 19:58:14 2020 +0000
tree 6e1f28910b524e0c49ca34ca9adf03a5bd447a74
parent af92348b1cdc4158e049d5a8d9e71ba7e054a87f

mesa: change error code of *TextureSubImage* for incorreect target

According to the "Errors" list of the OpenGL 4.6 spec, section 8.6
"Alternate Texture Image Specification Commands":

An INVALID_OPERATION error is generated by *TextureSubImage* if the
effective target of texture does not match the command, as shown in table 8.15.

Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5934>

src/mesa/main/teximage.c

diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index decd671..7a74ff2 100644
--- a/src/mesa/main/teximage.c
+++ b/src/mesa/main/teximage.c
@@ -3703,7 +3703,7 @@
    if (!no_error) {
       /* check target (proxies not allowed) */
       if (!legal_texsubimage_target(ctx, dims, texObj->Target, true)) {
-         _mesa_error(ctx, GL_INVALID_ENUM, "%s(target=%s)",
+         _mesa_error(ctx, GL_INVALID_OPERATION, "%s(target=%s)",
                      callerName, _mesa_enum_to_string(texObj->Target));
          return;
       }