commit 98cb57ad70fb7c8a9c030d3e83fe66b546906e28
author Vineet Gupta <vgupta@synopsys.com> Tue May 14 15:10:45 2019 -0700
committer Vineet Gupta <vgupta@synopsys.com> Mon Jul 01 11:02:22 2019 -0700
tree 0b287fc5aab7ea2f313379852b53cdd59971528b
parent d0542c7eacd5b507fa53570b610706df122a2f37

ARC: mm: do_page_fault refactor #6: error handlers to use same pattern

 - up_read
 - if !user_mode
 - whatever error handling

Signed-off-by: Vineet Gupta <vgupta@synopsys.com>

arch/arc/mm/fault.c

diff --git a/arch/arc/mm/fault.c b/arch/arc/mm/fault.c
index b107e45..2672ce2 100644
--- a/arch/arc/mm/fault.c
+++ b/arch/arc/mm/fault.c
@@ -191,22 +191,21 @@
 bad_area:
 	up_read(&mm->mmap_sem);
 
-	/* User mode accesses just cause a SIGSEGV */
-	if (user_mode(regs)) {
-		tsk->thread.fault_address = address;
-		force_sig_fault(SIGSEGV, si_code, (void __user *)address, tsk);
-		return;
-	}
+	if (!user_mode(regs))
+		goto no_context;
+
+	tsk->thread.fault_address = address;
+	force_sig_fault(SIGSEGV, si_code, (void __user *)address, tsk);
+	return;
 
 out_of_memory:
 	up_read(&mm->mmap_sem);
 
-	if (user_mode(regs)) {
-		pagefault_out_of_memory();
-		return;
-	}
+	if (!user_mode(regs))
+		goto no_context;
 
-	goto no_context;
+	pagefault_out_of_memory();
+	return;
 
 do_sigbus:
 	up_read(&mm->mmap_sem);