commit | 70a87287c821e9721b62463777f55ba588ac4623 | [log] [tgz] |
---|---|---|
author | Vasily Averin <vvs@virtuozzo.com> | Thu Jan 23 10:11:08 2020 +0300 |
committer | David S. Miller <davem@davemloft.net> | Fri Jan 24 11:42:18 2020 +0100 |
tree | 454501e4b7906e64fab12cb89223bf444bb693b4 | |
parent | 2bec445f9bf35e52e395b971df48d3e1e5dc704a [diff] |
seq_tab_next() should increase position index if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin <vvs@virtuozzo.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c index aca9f7a..4144c23 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
@@ -70,8 +70,7 @@ static void *seq_tab_next(struct seq_file *seq, void *v, loff_t *pos) { v = seq_tab_get_idx(seq->private, *pos + 1); - if (v) - ++*pos; + ++(*pos); return v; }