commit 9453d0a015779278f88228f391399a0e03e4cb5c
author Roberto Alanis <alanisbaez@google.com> Fri Sep 24 01:09:32 2021 +0000
committer Roberto Alanis <alanisbaez@google.com> Mon Oct 04 23:47:06 2021 +0000
tree d61c757a72b6931da4f798dba33c86609ff775b6
parent b3975981a7a47d91699f494e98680fb343a43f12

patch-check: Add shellcheck

Shellcheck is expected to be installed because depot_tools does not
provide the tool.

Change-Id: I4d09538359cdaf404d97f24782c4e5307225d0cc
Bug: b:185520494

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index a32af27..df27862 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -32,7 +32,10 @@
 See https://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
 details on the presubmit API built into depot_tools.
 """
+import subprocess2
+
 USE_PYTHON3 = True
+_INCLUDE_BASH_FILES_ONLY = [r".*\.sh$"]
 _INCLUDE_SOURCE_FILES_ONLY = [r".*\.(c|cc|[hc]pp|h)$"]
 _LIBWEBM_MAX_LINE_LENGTH = 80
 
@@ -45,6 +48,35 @@
                                                        sources)
 
 
+def _RunShellCheckCmd(input_api, output_api, bash_file):
+  """shellcheck command wrapper."""
+  cmd = ["shellcheck", "-x", "-oall", "-sbash", bash_file]
+  name = "Check %s file." % bash_file
+  start = input_api.time.time()
+  subprocess2.communicate(["shellcheck", "--version"])
+  output, rc = subprocess2.communicate(
+      cmd, stdout=None, stderr=subprocess2.PIPE, universal_newlines=True)
+  duration = input_api.time.time() - start
+  if rc == 0:
+    return output_api.PresubmitResult("%s\n%s (%4.2fs)\n" %
+                                      (name, " ".join(cmd), duration))
+  return output_api.PresubmitError("%s\n%s (%4.2fs) failed\n%s" %
+                                   (name, " ".join(cmd), duration, output[1]))
+
+
+def _CheckChangedShellCheckClean(input_api, output_api):
+  """Ensure shell scripts are clean."""
+  bash_sources = lambda x: input_api.FilterSourceFile(
+      x, files_to_check=_INCLUDE_BASH_FILES_ONLY, files_to_skip=None)
+
+  affected_bash_files = input_api.change.AffectedFiles(file_filter=bash_sources)
+  results = [
+      _RunShellCheckCmd(input_api, output_api, bash_file.AbsoluteLocalPath())
+      for bash_file in affected_bash_files
+  ]
+  return results
+
+
 def _CommonChecks(input_api, output_api):
   results = []
   results.extend(
@@ -72,6 +104,7 @@
   results = []
   results.extend(_CommonChecks(input_api, output_api))
   results.extend(_CheckChangeLintsClean(input_api, output_api))
+  results.extend(_CheckChangedShellCheckClean(input_api, output_api))
   return results
 
 
@@ -79,4 +112,5 @@
   results = []
   results.extend(_CommonChecks(input_api, output_api))
   results.extend(_CheckChangeLintsClean(input_api, output_api))
+  results.extend(_CheckChangedShellCheckClean(input_api, output_api))
   return results