commit ee40c7468c0a14d6db7227dc1640a63158861415
author Ian Rogers <irogers@google.com> Tue Sep 07 13:31:37 2021 -0700
committer Steven Rostedt (VMware) <rostedt@goodmis.org> Tue Oct 12 16:23:44 2021 -0400
tree f35b80d970fc1e94625ba5c59cb707915187a747
parent 17ad7da069f2773a26ccc7ad874573ca95a23a38

libtracefs: Fix sometimes uninitialized warning

The warning with clang looks like:

src/tracefs-sqlhist.c:1107:2: error: variable 'cmp' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
        default:
        ^~~~~~~
third_party/libtracefs/src/tracefs-sqlhist.c:1112:35: note: uninitialized use occurs here
                            filter->lval->field.field, cmp, val);
                                                       ^~~
third_party/libtracefs/src/tracefs-sqlhist.c:1033:2: note: variable 'cmp' is declared here
        enum tracefs_compare cmp;

Link: https://lore.kernel.org/linux-trace-devel/20210907203137.3954523-1-irogers@google.com

Signed-off-by: Ian Rogers <irogers@google.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

src/tracefs-sqlhist.c

diff --git a/src/tracefs-sqlhist.c b/src/tracefs-sqlhist.c
index 88e9675..d77ce86 100644
--- a/src/tracefs-sqlhist.c
+++ b/src/tracefs-sqlhist.c
@@ -1097,7 +1097,8 @@
 	case FILTER_BIN_AND:	cmp = TRACEFS_COMPARE_AND; break;
 	case FILTER_STR_CMP:	cmp = TRACEFS_COMPARE_RE; break;
 	default:
-		break;
+		fprintf(stderr, "Error invalid filter type '%d'", filter->type);
+		return ERANGE;
 	}
 
 	ret = append_filter(synth, TRACEFS_FILTER_COMPARE,